unminified build #37593

vsvamsi1 · 2024-11-20T09:57:19Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Warning

Tests have not run on the HEAD 8baa7e4 yet

Tue, 03 Dec 2024 12:21:00 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Chores
- Enhanced configuration for better source map generation.
- Disabled code minimization for improved debugging experience.

coderabbitai · 2024-11-20T09:57:28Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces changes to the craco.common.config.js file, specifically in the webpack.configure section. A new property devtool is added to enable source map generation, and the optimization section is modified to include a minimize property set to false. The configuration for icon cache groups remains unchanged, while comments and the ignoreWarnings array are preserved to maintain clarity regarding source maps and specific module warnings.

Changes

File	Change Summary
app/client/craco.common.config.js	- Added `devtool: "source-map"` under `webpack.configure`. - Updated `optimization` to include `minimize: false`. - Preserved comments in `optimization.splitChunks.cacheGroups.icons` and retained `ignoreWarnings` array.

Possibly related PRs

chore: reverted client profiled build #35306: Changes in the client-build.yml file regarding the build process may relate to the modifications in the craco.common.config.js file.
chore: Added pg branch #36086: Modifications to GitHub Actions workflow files that enhance build handling based on branches could be relevant to the changes in the craco.common.config.js.
chore: Trigger TBP on pg for scheduled run on release #36399: Removal of the is-pg-build parameter in the workflow configuration may connect to overall build process adjustments reflected in the craco.common.config.js.
chore: adds automation for request templates component #37140: Updates to the RequestTemplate component and its testing may relate to the overall configuration and build process.
chore: Update ADS button min width #37338: Changes to button styles in the design system could indirectly relate to the build process as UI components are affected by configuration settings.

Suggested labels

skip-changelog, ok-to-test, Task

Suggested reviewers

abhvsn
sharat87

🎉 In the config where the webpack plays,
A new devtool lights up the ways.
With minimization now set to false,
Source maps guide us, like a friendly pulse.
Comments preserved, warnings ignored,
A clearer path for builds, we’ve scored! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vsvamsi1 · 2024-11-20T09:57:43Z

/build-deploy-preview skip-tests=true

github-actions · 2024-11-20T09:58:08Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11930973095.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

vsvamsi1 · 2024-11-20T10:16:41Z

/build-deploy-preview skip-tests=true

github-actions · 2024-11-20T10:17:02Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11931296678.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

vsvamsi1 · 2024-11-20T10:21:54Z

/build-deploy-preview skip-tests=true

github-actions · 2024-11-20T10:22:18Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11931386061.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

vsvamsi1 · 2024-11-20T10:42:01Z

/build-deploy-preview

github-actions · 2024-11-20T10:42:26Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11931727846.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 37593.
recreate: .

vsvamsi1 · 2024-11-20T10:44:31Z

/build-deploy-preview skip-tests=true

github-actions · 2024-11-20T10:44:53Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11931766667.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

vsvamsi1 · 2024-11-20T10:58:23Z

/build-deploy-preview skip-tests=true

github-actions · 2024-11-20T10:58:45Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11931982584.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

github-actions · 2024-11-20T11:09:51Z

Deploy-Preview-URL: https://ce-37593.dp.appsmith.com

vsvamsi1 · 2024-11-20T11:59:10Z

/build-deploy-preview skip-tests=true

github-actions · 2024-11-20T11:59:35Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11932919735.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

vsvamsi1 · 2024-11-20T11:59:39Z

/build-deploy-preview skip-tests=true

github-actions · 2024-11-20T12:00:03Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11932925105.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

github-actions · 2024-11-20T12:13:49Z

Deploy-Preview-URL: https://ce-37593.dp.appsmith.com

github-actions · 2024-11-20T12:16:10Z

Deploy-Preview-URL: https://ce-37593.dp.appsmith.com

github-actions · 2024-11-27T16:39:42Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

vsvamsi1 · 2024-12-03T12:01:44Z

/build-deploy-preview skip-tests=true

github-actions · 2024-12-03T12:02:09Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12139207185.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

vsvamsi1 · 2024-12-03T12:09:06Z

/build-deploy-preview skip-tests=true

github-actions · 2024-12-03T12:09:30Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12139330799.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

vsvamsi1 · 2024-12-03T12:20:57Z

/build-deploy-preview skip-tests=true

github-actions · 2024-12-03T12:21:20Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12139531063.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

github-actions · 2024-12-03T12:24:07Z

Deploy-Preview-URL: https://ce-37593.dp.appsmith.com

github-actions · 2024-12-03T12:35:27Z

Deploy-Preview-URL: https://ce-37593.dp.appsmith.com

vsvamsi1 · 2024-12-06T11:23:15Z

/build-deploy-preview skip-tests=true

github-actions · 2024-12-06T11:23:35Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12197940319.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37593.
recreate: .

github-actions · 2024-12-06T11:37:31Z

Deploy-Preview-URL: https://ce-37593.dp.appsmith.com

github-actions · 2024-12-13T16:39:38Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions · 2024-12-21T16:36:33Z

This PR has been closed because of inactivity.

vsvamsi1 marked this pull request as draft November 20, 2024 09:57

fix

a7ee7b3

vsvamsi1 force-pushed the unminifiedBuild branch from 5bb39b7 to a7ee7b3 Compare November 20, 2024 11:59

github-actions bot added the Stale label Nov 27, 2024

added wrapper fn

d2326d2

added wrapper fn 1

6718e87

added wrapper fn 2

8baa7e4

github-actions bot removed the Stale label Dec 3, 2024

github-actions bot added the Stale label Dec 13, 2024

github-actions bot closed this Dec 21, 2024

unminified build #37593

unminified build #37593

Conversation

vsvamsi1 commented Nov 20, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Nov 20, 2024 • edited Loading

Review skipped

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

vsvamsi1 commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

vsvamsi1 commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

vsvamsi1 commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

vsvamsi1 commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

vsvamsi1 commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

vsvamsi1 commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

vsvamsi1 commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

vsvamsi1 commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 27, 2024

vsvamsi1 commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

vsvamsi1 commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

vsvamsi1 commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

vsvamsi1 commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 21, 2024

vsvamsi1 commented Nov 20, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Nov 20, 2024 •

edited

Loading