chore: reverted client profiled build #35306
Conversation
WalkthroughThe recent changes streamline the build process by removing the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/client-build.yml (1 hunks)
- app/client/build.sh (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/client-build.yml
- app/client/build.sh
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/client-build.yml (1 hunks)
- app/client/build.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/build.sh
Additional comments not posted (1)
.github/workflows/client-build.yml (1)
Line range hint
1-94:
Verify the impact of removing theAPPSMITH_CLOUD_HOSTINGenvironment variable.The removal of the
APPSMITH_CLOUD_HOSTINGenvironment variable might affect processes or scripts that rely on it during the build phase. Ensure that all dependent scripts and processes are updated accordingly to prevent any disruptions.Verification successful
No issues found with the removal of the
APPSMITH_CLOUD_HOSTINGenvironment variable.The search indicates that the
APPSMITH_CLOUD_HOSTINGenvironment variable is not used in any other scripts or workflows within the repository. Therefore, its removal does not impact other parts of the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if the `APPSMITH_CLOUD_HOSTING` environment variable is used in any other scripts or workflows. # Test: Search for the usage of `APPSMITH_CLOUD_HOSTING` in the repository. Expect: No occurrences of this variable. rg --type shell --type yaml --type json 'APPSMITH_CLOUD_HOSTING'Length of output: 94
Script:
#!/bin/bash # Description: Verify if the `APPSMITH_CLOUD_HOSTING` environment variable is used in any other scripts or workflows. # Test: Search for the usage of `APPSMITH_CLOUD_HOSTING` in the repository. Expect: No occurrences of this variable. rg --type sh --type yaml --type json 'APPSMITH_CLOUD_HOSTING'Length of output: 61
vsvamsi1
added
ok-to-test
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/client-build.yml (1 hunks)
- app/client/build.sh (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/client-build.yml
- app/client/build.sh
Description
Reverted client profiled build script, we will instead generate a docker custom image.
Fixes #35184
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10177617441
Commit: 3ff5d30
Cypress dashboard.
Tags:
@tag.SanitySpec:
Wed, 31 Jul 2024 09:52:14 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
APPSMITH_CLOUD_HOSTINGenvironment variable during the build process, streamlining the workflow and build script.