Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate cookie max-age using TimeFunc #249

Merged
merged 1 commit into from
Jun 6, 2020
Merged

calculate cookie max-age using TimeFunc #249

merged 1 commit into from
Jun 6, 2020

Conversation

JorritSalverda
Copy link
Contributor

fixes #248

@appleboy appleboy merged commit 653dcba into appleboy:master Jun 6, 2020
@appleboy appleboy added the bug label Jun 6, 2020
@appleboy
Copy link
Owner

appleboy commented Jun 6, 2020

@JorritSalverda Thanks

rayma-turingvideo added a commit to turingvideo/gin-jwt that referenced this pull request Jul 8, 2020
* chore: gin-jwt/v2 only support gin v1.5.0 or below (appleboy#238)

* udpate to gin 1.6.2 (appleboy#239)

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

* Fix documentation description of functions (appleboy#241)

* fixed readme descriptions

* fixed readme descriptions.

* chore: upgrade golang to 1.14 build

* chore: upgrade dependency

* Fix typo in README: Faliures -> Failures (appleboy#244)

* chore: upgrade gin to v1.6.3

* implements CookieMaxAge value (appleboy#245)

* docs: update comments of SigningAlgorithm field (appleboy#246)

* calculate cookie max-age using TimeFunc (appleboy#249)

* claim uuid for login and refresh

* go module

Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-authored-by: karimabedrabbo <karimnabedrabbo@gmail.com>
Co-authored-by: Andy Grunwald <andygrunwald@gmail.com>
Co-authored-by: skromez <42495435+skromez@users.noreply.github.com>
Co-authored-by: Jesús Rodríguez Pérez <jesusnoseq@hotmail.com>
Co-authored-by: Jorrit Salverda <JorritSalverda@users.noreply.github.com>
rayma-turingvideo added a commit to turingvideo/gin-jwt that referenced this pull request Jul 8, 2020
* chore: gin-jwt/v2 only support gin v1.5.0 or below (appleboy#238)

* udpate to gin 1.6.2 (appleboy#239)

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

* Fix documentation description of functions (appleboy#241)

* fixed readme descriptions

* fixed readme descriptions.

* chore: upgrade golang to 1.14 build

* chore: upgrade dependency

* Fix typo in README: Faliures -> Failures (appleboy#244)

* chore: upgrade gin to v1.6.3

* implements CookieMaxAge value (appleboy#245)

* docs: update comments of SigningAlgorithm field (appleboy#246)

* calculate cookie max-age using TimeFunc (appleboy#249)

* claim uuid for login and refresh

* go module

* fixes

Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-authored-by: karimabedrabbo <karimnabedrabbo@gmail.com>
Co-authored-by: Andy Grunwald <andygrunwald@gmail.com>
Co-authored-by: skromez <42495435+skromez@users.noreply.github.com>
Co-authored-by: Jesús Rodríguez Pérez <jesusnoseq@hotmail.com>
Co-authored-by: Jorrit Salverda <JorritSalverda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie max age should be calculated using TimeFunc
2 participants