implements CookieMaxAge value #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleboy
approved these changes
May 16, 2020
rayma-turingvideo
added a commit
to turingvideo/gin-jwt
that referenced
this pull request
Jul 8, 2020
* chore: gin-jwt/v2 only support gin v1.5.0 or below (appleboy#238) * udpate to gin 1.6.2 (appleboy#239) Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com> * Fix documentation description of functions (appleboy#241) * fixed readme descriptions * fixed readme descriptions. * chore: upgrade golang to 1.14 build * chore: upgrade dependency * Fix typo in README: Faliures -> Failures (appleboy#244) * chore: upgrade gin to v1.6.3 * implements CookieMaxAge value (appleboy#245) * docs: update comments of SigningAlgorithm field (appleboy#246) * calculate cookie max-age using TimeFunc (appleboy#249) * claim uuid for login and refresh * go module Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com> Co-authored-by: karimabedrabbo <karimnabedrabbo@gmail.com> Co-authored-by: Andy Grunwald <andygrunwald@gmail.com> Co-authored-by: skromez <42495435+skromez@users.noreply.github.com> Co-authored-by: Jesús Rodríguez Pérez <jesusnoseq@hotmail.com> Co-authored-by: Jorrit Salverda <JorritSalverda@users.noreply.github.com>
rayma-turingvideo
added a commit
to turingvideo/gin-jwt
that referenced
this pull request
Jul 8, 2020
* chore: gin-jwt/v2 only support gin v1.5.0 or below (appleboy#238) * udpate to gin 1.6.2 (appleboy#239) Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com> * Fix documentation description of functions (appleboy#241) * fixed readme descriptions * fixed readme descriptions. * chore: upgrade golang to 1.14 build * chore: upgrade dependency * Fix typo in README: Faliures -> Failures (appleboy#244) * chore: upgrade gin to v1.6.3 * implements CookieMaxAge value (appleboy#245) * docs: update comments of SigningAlgorithm field (appleboy#246) * calculate cookie max-age using TimeFunc (appleboy#249) * claim uuid for login and refresh * go module * fixes Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com> Co-authored-by: karimabedrabbo <karimnabedrabbo@gmail.com> Co-authored-by: Andy Grunwald <andygrunwald@gmail.com> Co-authored-by: skromez <42495435+skromez@users.noreply.github.com> Co-authored-by: Jesús Rodríguez Pérez <jesusnoseq@hotmail.com> Co-authored-by: Jorrit Salverda <JorritSalverda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements a feature that allows to choose how long the cookie will be valid, and also using mw.Timeout value for a cookie isn't right, since it's just not possible to refresh a jwt if maxAge of cookie is the same as jwt timeout value if the user has chosen to store jwt in cookies
If you don't want to implement that feature I'd ask you to update maxAge value in cookie to be
expireCookie := mw.TimeFunc().Add(mw.CookieMaxAge)maxage := int(expireCookie.Unix() - time.Now().Unix())and not
expire := mw.TimeFunc().Add(mw.Timeout)so user would be at least able to refresh a token if it's stored in cookies.