alloc tests: hook posix_memalign & reallocf (#782) #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Swift started using posix_memalign very recently (Jan 2019) so we need to hook that too to get correct results. Modifications: Hook posix_memalign, reallocf & valloc Result: alloc tests should pass again (cherry picked from commit de8d3e2)
Lukasa
approved these changes
Apr 8, 2019
|
We're ignoring the Swift 5 test failure here: @weissi assures me that he expected that failure and that it's not relevant right now. |
|
5.0 failure is expected because the docker file only comes in #952 (which can't go in ahead of this one because this backports the allocation counter fixes for Swift 5 from |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift started using posix_memalign very recently (Jan 2019) so we need
to hook that too to get correct results.
Modifications:
Hook posix_memalign, reallocf & valloc
Result:
alloc tests should pass again
(cherry picked from commit de8d3e2)