swift 5 docker support #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: easily build and test swift-nio v1 using swift 5 docker Modifications: adjust dockerfile and add docker-compose file for ubuntu 18.04, swift 5
|
@swift-nio-bot test this please |
|
@weissi per your request, added swift 5 PRBs. looks like the integration tests are failing tho |
weissi
approved these changes
Apr 6, 2019
|
@swift-nio-bot test this please |
|
@swift-nio-bot test this please |
|
(retested because spurious test error (more than 20% overhead from the syscall wrappers) |
|
blocked behind #954 |
|
@swift-nio-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: easily build and test swift-nio v1 using swift 5 docker
Modifications: adjust dockerfile and add docker-compose file for ubuntu 18.04, swift 5