Feature/jo/state managed udp #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Jul 8, 2023
Sources/NIOTransportServices/Datagram/NIOTSDatagramBootstrap.swift
Outdated
Show resolved
Hide resolved
Sources/NIOTransportServices/Datagram/NIOTSDatagramBootstrap.swift
Outdated
Show resolved
Hide resolved
Sources/NIOTransportServices/Datagram/NIOTSDatagramChannel.swift
Outdated
Show resolved
Hide resolved
Sources/NIOTransportServices/Datagram/NIOTSDatagramChannel.swift
Outdated
Show resolved
Hide resolved
Sources/NIOTransportServices/Datagram/NIOTSDatagramListenerChannel.swift
Show resolved
Hide resolved
Sources/NIOTransportServices/Datagram/NIOTSDatagramListenerChannel.swift
Show resolved
Hide resolved
Joannis
force-pushed
the
feature/jo/state-managed-udp
branch
from
13a6a6f to
adfcaeb
Compare
|
@Lukasa updated |
|
Note that there were 2 small issues in the state managed channels that I've had to fix as well |
Lukasa
reviewed
Jul 20, 2023
Sources/NIOTransportServices/Datagram/NIOTSDatagramBootstrap.swift
Outdated
Show resolved
Hide resolved
Sources/NIOTransportServices/Datagram/NIOTSDatagramListener.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Cory Benfield <lukasa@apple.com>
Lukasa
reviewed
Aug 9, 2023
Sources/NIOTransportServices/Datagram/NIOTSDatagramListener.swift
Outdated
Show resolved
Hide resolved
Lukasa
approved these changes
Aug 10, 2023
Lukasa
requested changes
Aug 10, 2023
Tests/NIOTransportServicesTests/NIOTSDatagramConnectionChannelTests.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for UDP clients and servers.
Motivation:
This change was made because UDP support was lacking on iOS. It's needed by my DNS client implementation, which I am in turn using for an iOS app I'm working on relying on SRV typed records.
Modifications:
NIOTSDatagramListenerBootstrapfor making UDP servicesNIOTSDatagramListenerChannelthat accepts UDP connectionsNIOTSDatagramChannelfor UDP client connectionsNIOTSDatagramBootstrapthat can create a new UDP clientNotes
This PR relies on #174 and #175, but it separated so that it's easy to review.
This has been tested against my own libraries, but only features one test.
While I believe it to be working, I'm looking for feedback on how I can better test this implementation.