Extract the NWConnection code into StateManagedNWConnectionChannel #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In hindsight, I do think it's valuable to also add a common implementation for listener channels, and add that to UDP right away as well. Give me a bit more time. EDIT: It'll be a second PR. |
This was referenced May 21, 2023
Merged
Lukasa
reviewed
May 24, 2023
Tests/NIOTransportServicesTests/NIOFilterEmptyWritesHandlerTests.swift
Outdated
Show resolved
Hide resolved
Sources/NIOTransportServices/StateManagedNWConnectionChannel.swift
Outdated
Show resolved
Hide resolved
|
Updated now! I removed the lock from |
Lukasa
reviewed
May 26, 2023
…the underscores to the addressCache properties
|
Updated @Lukasa , thanks for the quick reviews thus far. And have a nice weekend for now :) |
|
Ping @Lukasa |
|
@swift-server-bot add to allowlist |
|
To try to get this landed I took the liberty of just fixing the soundness violation myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the NWConnection code into StateManagedNWConnectionChannel
Motivation:
When implementing #68, a lot of code ended up being identical between TCP and UDP. This PR paves the way to adding UDP, with very little overhead code. It moves the code that is used to represent NWConnection as a Channel into its own protocol, that can then be applied to both TCP and UDP implementations.
Modifications:
StateManagedNWConnectionChannelthat has all the logic for handling a NWConnection as a NIO.Channel.NWOptionsProtocolthat can read and write socket options. This is applied toNWProtocolTCP.OptionStateManagedNWConnectionChannelhandles the common denominators between TCP and the future UDP implementaitonNWConnectionSubstatethat can handle changes in the ChannelState.Result:
This makes implementing UDP much simpler, and without redundant code.