Remove incorrect assertions from logging lifecycle observers #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If request is retried multiple times, multiple callbacks can be invoked multiple times (for every retry attempt) when logging observers are applied at the client level. Modifications: - Remove some assertions from `LoggingGrpcLifecycleObserver` and `LoggingHttpLifecycleObserver`; - Clarify some expectations in `HttpLifecycleObserver` javadoc; Result: No `AssertionError` in tests that can retry.
idelpivnitskiy
force-pushed
the
logging-observers
branch
from
3d0921b to
423a321
Compare
idelpivnitskiy
changed the title
onConnectionSelected
daschl
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If request is retried multiple times, multiple callbacks can be invoked
multiple times (for every retry attempt) when logging observers are
applied at the client level.
Modifications:
LoggingGrpcLifecycleObserverandLoggingHttpLifecycleObserver;HttpLifecycleObserverjavadoc;Result:
No
AssertionErrorin tests that can retry.