-
Notifications
You must be signed in to change notification settings - Fork 184
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove assertion from logging observers
onConnectionSelected
Motivation: If request is retried multiple times, `onConnectionSelected` callback will be invoked multiple times (for every retry attempt) when logging observers are applied at the client level. Modifications: - Remove `assert this.connInfo == null` from `LoggingGrpcLifecycleObserver` and `LoggingHttpLifecycleObserver`; - Clarify expectations in `HttpLifecycleObserver` javadoc; Result: No `AssertionError` in tests that can retry.
- Loading branch information
1 parent
3843dd4
commit 3d0921b
Showing
3 changed files
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters