Do not hardcode netty-tcnative version in docs #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Existing `performance.adoc` has hardcoded version of netty-tcnative which is already outdated. Modifications: - Change the hardcoded version number to a parameter and link where users can find the latest version number; Result: No outdated version constant in docs.
bondolo
approved these changes
May 21, 2021
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
Motivation: Existing `performance.adoc` has a hardcoded version of netty-tcnative which is already outdated. Modifications: - Change the hardcoded version number to a parameter and link where users can find the latest version number; Result: No outdated version constant in docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Existing
performance.adochas hardcoded version of netty-tcnativewhich is already outdated.
Modifications:
users can find the latest version number;
Result:
No outdated version constant in docs.