Skip to content

Commit

Permalink
Do not hardcode netty-tcnative version in docs (#1571)
Browse files Browse the repository at this point in the history
Motivation:

Existing `performance.adoc` has a hardcoded version of netty-tcnative
which is already outdated.

Modifications:

- Change the hardcoded version number to a parameter and link where
users can find the latest version number;

Result:

No outdated version constant in docs.
  • Loading branch information
idelpivnitskiy authored May 21, 2021
1 parent 253c34d commit 57f1071
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion docs/modules/ROOT/pages/performance.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -585,14 +585,17 @@ link:https://wiki.mozilla.org/Security/Server_Side_TLS[Mozilla Server Side TLS])
[source, java]
----
// add the netty dependency to your build, eg: "io.netty:netty-tcnative-boringssl-static:2.0.25.Final"
// add the netty dependency to your build, eg: "io.netty:netty-tcnative-boringssl-static:$tcnativeVersion"
BlockingHttpClient client = HttpClients.forSingleAddress("servicetalk.io", 443)
.secure().provider(SecurityConfigurator.SslProvider.OPENSSL).commit()
.buildBlocking();
HttpResponse resp = client.request(client.get("/"));
----

Latest `netty-tcnative-boringssl-static` version can be found in
link:https://search.maven.org/artifact/io.netty/netty-tcnative-boringssl-static[Maven Central Repository].

=== Netty LEAK-detection
ServiceTalk is built on top of Netty. Netty supports
xref:{page-version}@servicetalk::performance.adoc#reference-counting[reference counting] of `ByteBuf` objects (reference
Expand Down

0 comments on commit 57f1071

Please sign in to comment.