Do not use TLSv1.1 in tests #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are no longer considered secure. As the result of this JDK upgrade, `SecureTcpTransportObserverErrorsTest.testSslErrors` started to fail when it uses JDK provider with TLSv1.1. Modifications: - Use TLSv1.3 instead of TLSv1.1 for `SecureTcpTransportObserverErrorsTest`; Result: Fixes apple#1530.
Closed
Scottmitch
approved these changes
May 7, 2021
idelpivnitskiy
added a commit
that referenced
this pull request
May 7, 2021
Motivation: TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are no longer considered secure. As the result of this JDK upgrade, `SecureTcpTransportObserverErrorsTest.testSslErrors` started to fail when it uses JDK provider with TLSv1.1. Modifications: - Use TLSv1.3 instead of TLSv1.1 for `SecureTcpTransportObserverErrorsTest`; Result: Fixes #1530.
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
Motivation: TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are no longer considered secure. As the result of this JDK upgrade, `SecureTcpTransportObserverErrorsTest.testSslErrors` started to fail when it uses JDK provider with TLSv1.1. Modifications: - Use TLSv1.3 instead of TLSv1.1 for `SecureTcpTransportObserverErrorsTest`; Result: Fixes apple#1530.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are
no longer considered secure [1, 2]. As the result of this JDK upgrade,
SecureTcpTransportObserverErrorsTest.testSslErrorsstarted to fail whenit uses JDK provider with TLSv1.1.
Modifications:
SecureTcpTransportObserverErrorsTest;Result:
Fixes #1530.