Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: SecureTcpTransportObserverErrorsTest#testSslErrors #1530

Closed
idelpivnitskiy opened this issue May 6, 2021 · 2 comments · Fixed by #1533
Closed

Flaky test: SecureTcpTransportObserverErrorsTest#testSslErrors #1530

idelpivnitskiy opened this issue May 6, 2021 · 2 comments · Fixed by #1533
Labels
flaky tests Unit tests are flaky

Comments

@idelpivnitskiy
Copy link
Member

https://github.com/apple/servicetalk/runs/2521994553

SecureTcpTransportObserverErrorsTest > testSslErrors[errorReason=NOT_MATCHING_PROTOCOLS, clientProvider=JDK, serverProvider=JDK] FAILED
    org.junit.runners.model.TestTimedOutException: test timed out after 90000 milliseconds
        at java.lang.Thread.sleep(Native Method)
        at org.mockito.internal.verification.VerificationOverTimeImpl.sleep(VerificationOverTimeImpl.java:117)
        at org.mockito.internal.verification.VerificationOverTimeImpl.handleVerifyException(VerificationOverTimeImpl.java:100)
        at org.mockito.internal.verification.VerificationOverTimeImpl.verify(VerificationOverTimeImpl.java:89)
        at org.mockito.internal.verification.VerificationWrapper.verify(VerificationWrapper.java:19)
        at org.mockito.internal.verification.MockAwareVerificationMode.verify(MockAwareVerificationMode.java:27)
        at org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:72)
        at org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29)
        at org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:35)
        at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:61)
        at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:49)
        at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor$DispatcherDefaultingToRealMethod.interceptAbstract(MockMethodInterceptor.java:126)
        at io.servicetalk.transport.api.ConnectionObserver$SecurityHandshakeObserver$MockitoMock$664195828.handshakeFailed(Unknown Source)
        at io.servicetalk.tcp.netty.internal.SecureTcpTransportObserverErrorsTest.testSslErrors(SecureTcpTransportObserverErrorsTest.java:206)

SecureTcpTransportObserverErrorsTest > testSslErrors[errorReason=NOT_MATCHING_PROTOCOLS, clientProvider=OPENSSL, serverProvider=JDK] FAILED
    org.junit.runners.model.TestTimedOutException: test timed out after 90000 milliseconds
        at java.lang.Thread.sleep(Native Method)
        at org.mockito.internal.verification.VerificationOverTimeImpl.sleep(VerificationOverTimeImpl.java:117)
        at org.mockito.internal.verification.VerificationOverTimeImpl.handleVerifyException(VerificationOverTimeImpl.java:100)
        at org.mockito.internal.verification.VerificationOverTimeImpl.verify(VerificationOverTimeImpl.java:89)
        at org.mockito.internal.verification.VerificationWrapper.verify(VerificationWrapper.java:19)
        at org.mockito.internal.verification.MockAwareVerificationMode.verify(MockAwareVerificationMode.java:27)
        at org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:72)
        at org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29)
        at org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:35)
        at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:61)
        at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:49)
        at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor$DispatcherDefaultingToRealMethod.interceptAbstract(MockMethodInterceptor.java:126)
        at io.servicetalk.transport.api.ConnectionObserver$SecurityHandshakeObserver$MockitoMock$664195828.handshakeFailed(Unknown Source)
        at io.servicetalk.tcp.netty.internal.SecureTcpTransportObserverErrorsTest.testSslErrors(SecureTcpTransportObserverErrorsTest.java:206)
@idelpivnitskiy idelpivnitskiy added the flaky tests Unit tests are flaky label May 6, 2021
@idelpivnitskiy
Copy link
Member Author

It started to happen more frequently. I can reproduce it only inside linux VM

@idelpivnitskiy
Copy link
Member Author

I'm not sure how that happened that I could reproduce it locally, but I can not anymore 😞

idelpivnitskiy added a commit to idelpivnitskiy/servicetalk that referenced this issue May 7, 2021
@idelpivnitskiy
Debug apple#1530
0662575
idelpivnitskiy added a commit to idelpivnitskiy/servicetalk that referenced this issue May 7, 2021
@idelpivnitskiy
Do not use TLSv1.1 in tests
19e98a9 
Motivation:

TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are
no longer considered secure. As the result of this JDK upgrade,
`SecureTcpTransportObserverErrorsTest.testSslErrors` started to fail when
it uses JDK provider with TLSv1.1.

Modifications:

- Use TLSv1.3 instead of TLSv1.1 for `SecureTcpTransportObserverErrorsTest`;

Result:

Fixes apple#1530.
@idelpivnitskiy idelpivnitskiy mentioned this issue May 7, 2021
Merged
idelpivnitskiy added a commit that referenced this issue May 7, 2021
@idelpivnitskiy
Do not use TLSv1.1 in tests (#1533)
65a77cb 
Motivation:

TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are
no longer considered secure. As the result of this JDK upgrade,
`SecureTcpTransportObserverErrorsTest.testSslErrors` started to fail when
it uses JDK provider with TLSv1.1.

Modifications:

- Use TLSv1.3 instead of TLSv1.1 for `SecureTcpTransportObserverErrorsTest`;

Result:

Fixes #1530.
idelpivnitskiy added a commit that referenced this issue May 7, 2021
@idelpivnitskiy
Do not use TLSv1.1 in tests (#1533)
53d5329 
Motivation:

TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are
no longer considered secure. As the result of this JDK upgrade,
`SecureTcpTransportObserverErrorsTest.testSslErrors` started to fail when
it uses JDK provider with TLSv1.1.

Modifications:

- Use TLSv1.3 instead of TLSv1.1 for `SecureTcpTransportObserverErrorsTest`;

Result:

Fixes #1530.
hbelmiro pushed a commit to hbelmiro/servicetalk that referenced this issue May 23, 2021
@idelpivnitskiy @hbelmiro
Do not use TLSv1.1 in tests (apple#1533)
ea502eb 
Motivation:

TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are
no longer considered secure. As the result of this JDK upgrade,
`SecureTcpTransportObserverErrorsTest.testSslErrors` started to fail when
it uses JDK provider with TLSv1.1.

Modifications:

- Use TLSv1.3 instead of TLSv1.1 for `SecureTcpTransportObserverErrorsTest`;

Result:

Fixes apple#1530.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky tests Unit tests are flaky
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not use TLSv1.1 in tests idelpivnitskiy/servicetalk
1 participant
@idelpivnitskiy