Implement CharSequences#parseLong(CharSequence)
#1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 0.5.x plugin version can not run newer JMH versions.
Motivation: Our `HttpHeaders` API uses `CharSequence`. In order for users to parse the value (like, `Content-Length`) they have to convert `CharSequence` to `String` for `Long.parseLong(String)` API. This approach does an extra copy if data from underlying `Buffer`. We can avoid it. Modifications: - Add `CharSequences#parseLong(CharSequence)` API that does not force `CharSequence#toString()` conversion; - Add tests to validate new API; - Use the new API in all places when we parse an `AsciiBuffer` or `AsciiString`; Result: Less allocations of `String`.
bondolo
approved these changes
Apr 2, 2021
servicetalk-buffer-api/src/main/java/io/servicetalk/buffer/api/CharSequences.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our
HttpHeadersAPI usesCharSequence. In order for users to parsethe value (like,
Content-Length) they have to convertCharSequenceto
StringforLong.parseLong(String)API. This approach does an extracopy of data from underlying
Buffer. We can avoid it.Modifications:
CharSequences#parseLong(CharSequence)API that does not forceCharSequence#toString()conversion;AsciiBufferorAsciiString;Result:
Less allocations of
String.This PR depends on #1468 (ignore first commit).