Update JMH 1.28 -> 1.29 and me.champeau.jmh plugin 0.5.3 -> 0.6.3 #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelpivnitskiy
commented
Apr 2, 2021
| jvmArgsPrepend = "-Dio.netty.maxDirectMemory=9223372036854775807 " + | ||
| "-Djmh.executor=CUSTOM " + | ||
| "-Djmh.executor.class=io.servicetalk.benchmark.concurrent.AsyncContextFriendlyExecutor" | ||
| jvmArgsPrepend = ["-Dio.netty.maxDirectMemory=9223372036854775807 " + |
There was a problem hiding this comment.
The plugin was reworked. It uses a new method of running JMH now, which does not cause issues with gradle cache, but the API for configuration is a bit buggy. For example, it requires an array now, but still needs manual string assembly instead of adding properties as separate array elements.
Motivation: 0.5.x plugin version can not run newer JMH versions.
idelpivnitskiy
force-pushed
the
jmh-plugin
branch
from
b33aea0 to
1feb0a3
Compare
bondolo
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
0.5.x plugin version can not run newer JMH versions.