Github Actions dawidd6/action-download-artifact set workflow_conclusion #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ec26d27 updated dawidd6/action-download-artifact which changed the default behavior of workflow_conclusion from "completed" to "completed,success". This may result in failure of downloading test results for pull request builder. Modifications: - explicitly set workflow_conclusion to "completed" Result: Unit test and quality results are downloaded to generate reports.
|
tested on my local fork (https://github.com/Scottmitch/servicetalk-1/runs/2125698762?check_suite_focus=true), however may require followup... |
|
will merge so I can see test errors in other PRs, will followup as necessary. |
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this pull request
Mar 16, 2021
…on (apple#1441) Motivation: ec26d27 updated dawidd6/action-download-artifact which changed the default behavior of workflow_conclusion from "completed" to "completed,success". This may result in failure of downloading test results for pull request builder. Modifications: - explicitly set workflow_conclusion to "completed" Result: Unit test and quality results are downloaded to generate reports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ec26d27 updated
dawidd6/action-download-artifact which changed the default behavior of
workflow_conclusion from "completed" to "completed,success". This may
result in failure of downloading test results for pull request builder.
Modifications:
Result:
Unit test and quality results are downloaded to generate reports.