Skip to content

Commit

Permalink
Github Actions dawidd6/action-download-artifact set workflow_conclusi…
Browse files Browse the repository at this point in the history
…on (#1441)

Motivation:
ec26d27 updated
dawidd6/action-download-artifact which changed the default behavior of
workflow_conclusion from "completed" to "completed,success". This may
result in failure of downloading test results for pull request builder.

Modifications:
- explicitly set workflow_conclusion to "completed"

Result:
Unit test and quality results  are downloaded to generate reports.
  • Loading branch information
Scottmitch authored Mar 16, 2021
1 parent 1306f84 commit 627c354
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci-prb-reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: ${{ github.event.workflow_run.workflow_id }}
workflow_conclusion: completed
commit: ${{ github.event.workflow_run.head_commit.id }}
# File location set in ci-prb.yml and must be coordinated.
name: test-results-${{ matrix.os }}-${{ matrix.java }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci-prq-reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: ${{ github.event.workflow_run.workflow_id }}
workflow_conclusion: completed
commit: ${{ github.event.workflow_run.head_commit.id }}
name: checkstyle-results-${{ matrix.java }}
- name: Publish Checkstyle Report
Expand All @@ -38,6 +39,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: ${{ github.event.workflow_run.workflow_id }}
workflow_conclusion: completed
commit: ${{ github.event.workflow_run.head_commit.id }}
name: pmd-results-${{ matrix.java }}
- name: Publish PMD Report
Expand All @@ -60,6 +62,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: ${{ github.event.workflow_run.workflow_id }}
workflow_conclusion: completed
commit: ${{ github.event.workflow_run.head_commit.id }}
name: spotbugs-results-${{ matrix.java }}
- name: Publish SpotBugs Report
Expand Down

0 comments on commit 627c354

Please sign in to comment.