Remove obsolete and unproductive JVM options #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The current JVM options used for running ServiceTalk tests have not recently been updated to reflect current recommendations. Modifications: Remove "-XX:+AggressiveOpts", "-XX:+TieredCompilation", "-XX:+UseBiasedLocking", and "-XX:+OptimizeStringConcat" options. "-XX:+TieredCompilation" and "-XX:+OptimizeStringConcat" are now default behaviour "-XX:+AggressiveOpts" is likely to slow performance and was removed in JDK12. "-XX:+UseBiasedLocking" is likely to slow performance for ServiceTalk workloads and was removed in JDK15 Result: ServiceTalk tests executed with JVM options which more likely to reflect typical current production usage.
Scottmitch
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current JVM options used for running ServiceTalk tests have not recently been updated
to reflect current recommendations.
Modifications:
Remove "-XX:+AggressiveOpts", "-XX:+TieredCompilation", "-XX:+UseBiasedLocking",
and "-XX:+OptimizeStringConcat" options.
"-XX:+TieredCompilation" and "-XX:+OptimizeStringConcat" are now default behaviour
"-XX:+AggressiveOpts" is likely to slow performance and was removed in JDK12.
"-XX:+UseBiasedLocking" is likely to slow performance for ServiceTalk workloads and was
removed in JDK15
Result:
ServiceTalk tests executed with JVM options which more likely to reflect typical current
production usage.