Skip to content

Commit

Permalink
Remove obsolete and unproductive JVM options (#1437)
Browse files Browse the repository at this point in the history
Motivation:
The current JVM options used for running ServiceTalk tests have not recently been updated
to reflect current recommendations.

Modifications:
Remove "-XX:+AggressiveOpts", "-XX:+TieredCompilation", "-XX:+UseBiasedLocking",
 and "-XX:+OptimizeStringConcat" options.
"-XX:+TieredCompilation" and "-XX:+OptimizeStringConcat" are now default behaviour
"-XX:+AggressiveOpts" is likely to slow performance and was removed in JDK12.
"-XX:+UseBiasedLocking" is likely to slow performance for ServiceTalk workloads and was
removed in JDK15

Result:
ServiceTalk tests executed with JVM options which more likely to reflect typical current
production usage.
  • Loading branch information
bondolo authored Mar 16, 2021
1 parent ecb85bd commit bf7b3a2
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,7 @@ final class ServiceTalkLibraryPlugin extends ServiceTalkCorePlugin {
}

jvmArgs "-server", "-Xms2g", "-Xmx4g", "-dsa", "-da", "-ea:io.servicetalk...",
"-XX:+AggressiveOpts", "-XX:+TieredCompilation", "-XX:+UseBiasedLocking",
"-XX:+OptimizeStringConcat", "-XX:+HeapDumpOnOutOfMemoryError"
"-XX:+HeapDumpOnOutOfMemoryError"
}
}
}
Expand Down

0 comments on commit bf7b3a2

Please sign in to comment.