Add remote hosted endpoint support #2915
Conversation
(mainly directly copied from enterprise gateway)
packages/apollo-gateway/src/__tests__/integration/networkRequests.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@JacksonKearl this is a great start! Super exciting to see this come together! Can you sync with @trevor-scheer on his current work on observability and control points that may impact this? SO excited to get this in!
packages/apollo-gateway/src/__tests__/integration/networkRequests.test.ts
Outdated
Show resolved
Hide resolved
| mockGetCompositionConfigLink(); | ||
| mockGetCompositionConfigs(); | ||
| mockGetImplementingServices(); | ||
| mockGetRawPartialSchema(); |
There was a problem hiding this comment.
Since these are async in the actual code, I think we should make these match the call ordering and make them async here as well
There was a problem hiding this comment.
Bit confused. The installation of the mock is synchronous.
packages/apollo-gateway/src/__tests__/integration/networkRequests.test.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,114 @@ | |||
| import nock from 'nock'; | |||
|
|
|||
| export const mockLocalhostSDLQuery = () => | |||
There was a problem hiding this comment.
I think we should provide a way to override the results of these requests so we can test error handling better
| export interface HostedGatewayConfig extends GatewayConfigBase { | ||
| apiKey?: string; | ||
| tag?: string; | ||
| federationVersion?: number; |
There was a problem hiding this comment.
@JacksonKearl I know that @trevor-scheer has been thinking through fallbacks and control overrides for fetching from the managed system in case of failure. I wonder if we should merge all three of these configs together into a simpler apiKey + serviceList / way to fetch services?
Can you sync with him on those ideas?
This enables config after construction.
JacksonKearl
force-pushed
the
enterprise-merge/remoteHostedServiceLists
branch
2 times, most recently
from
cf5abb1 to
3e769f1
Compare
|
I have no clue how to revert the merge. |
|
Nvm |
packages/apollo-gateway/src/__tests__/integration/networkRequests.test.ts
Outdated
Show resolved
Hide resolved
packages/apollo-gateway/src/__tests__/integration/networkRequests.test.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Jesse Rosenberger <git@jro.cc>
|
Merging into staging now because can't really build anything on top of these while all the components are implemented on independent branches. |
…teHostedServiceLists
(mainly directly copied from enterprise gateway)
Feedback on best testing mechanism appreciated. There are a bunch of GCS calls made for the various links, so my approach was to install a
nock.recoder, get a trace of all of the requests, and install the mocks in various tests, in each test asserting that each of the relevant mocks was appropriately called.