Add polling support #2914
Merged
Add polling support #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jbaxleyiii
reviewed
Jun 25, 2019
There was a problem hiding this comment.
@JacksonKearl after a few discussions with some users of federation, I think we should ultimately scrap this PR for now. The tldr; is that we are more and more convinced that a live "pull" based model is a footgun that will end up causing a lot more pain than success for users. As new services are incrementally rolled out, the gateway would end up "flapping" (going from old to new to old to new) during its poll timing.
I think we should work with the community to find a great answer to a "push" model for updating the gateway instead
|
@jbaxleyiii So we're bringing this back? |
|
Merged this into enterprise-merge/remoteHostedServiceLists, as they're pretty intertwined. |
|
Merged into #2915 |
|
Actually nvm |
JacksonKearl
force-pushed
the
enterprise-merge/polling
branch
from
3e769f1 to
447eb07
Compare
abernix
approved these changes
Jun 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for polling to OSS. The code is mainly taken from enterprise-gateway, but with the support for dynamically adding and removing listeners removed, as it complicates the code significantly and I'm not sure what the use case is. Happy to add it back if needed.