Skip to content

Commit

Permalink
no-op: Add back comment about ftv1 trace format.
Browse files Browse the repository at this point in the history
This was inadvertently removed in the re-factor.

Ref: https://github.com/apollographql/apollo-server/pull/3998/files#r414901517
  • Loading branch information
abernix committed Apr 27, 2020
1 parent dce4a24 commit a8ab841
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/apollo-engine-reporting/src/federatedPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { EngineReportingOptions } from "./agent";

type FederatedReportingOptions<TContext> = Pick<EngineReportingOptions<TContext>, 'rewriteError'>

// This ftv1 plugin produces a base64'd Trace protobuf containing only the

This comment has been minimized.

Copy link
@glasser

glasser Apr 28, 2020

Member

Now that this is farther from the assignment, mention that it goes on the extensions.ftv1 output field?

// durationNs, startTime, endTime, and root fields.
const federatedPlugin = <TContext>(
options: FederatedReportingOptions<TContext> = Object.create(null),
): ApolloServerPlugin<TContext> => {
Expand Down

0 comments on commit a8ab841

Please sign in to comment.