Skip to content

Commit

Permalink
fix!: Rename AERs newExtension to newPlugin to match new usage.
Browse files Browse the repository at this point in the history
Ref: #3998
  • Loading branch information
abernix committed Apr 27, 2020
1 parent c67a6df commit dce4a24
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/apollo-engine-reporting/src/agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ export class EngineReportingAgent<TContext = any> {
handleLegacyOptions(this.options);
}

public newExtension(): ApolloServerPlugin<TContext> {
public newPlugin(): ApolloServerPlugin<TContext> {
return plugin(this.options, this.addTrace.bind(this));
}

Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-core/src/ApolloServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ export class ApolloServerBase {
'to report metrics to Apollo Graph Manager.',
);
}
pluginsToInit.push(this.engineReportingAgent!.newExtension());
pluginsToInit.push(this.engineReportingAgent!.newPlugin());
} else if (engine !== false && federatedSchema) {
// We haven't configured this app to use Engine directly. But it looks like
// we are a federated service backend, so we should be capable of including
Expand Down

0 comments on commit dce4a24

Please sign in to comment.