Fix client.version to reflect @apollo/client version. #7448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been lost in #5292, when we reorganized everything from a monorepo with multiple
packages/(where it was handled bypackages/apollo-client/scripts/deploy.sh) to a single package with multiple entry points. Instead of providing a useful version like"3.3.4",client.versionis just"local".I've tested that this works manually (usingTests added!npm run build), meaning the actual version shows up in bothdist/version.js(for ESM) anddist/core/core.cjs.js(for CommonJS), but I'm not sure how best to create a regression test, since most of our current tests run before/withoutnpm run build.