Decommission the monorepo #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll be handling this differently with Apollo Client 3.0.
This was originally created to help promote contributions from people working for oranizations that required author names to be included with contributions. We haven't received any requests for this kind of user contribution tracking in quite some time, so let's assume it is no longer needed.
The `refactoring` folder is temporary and holds all config and other support related files from each child package, that won't be part of the new no monorepo approach, but we still neeed for reference during refactoring.
These new locations will more than likely be temporary. They're being moved to get them out of their separate package locations, so those packages can be de-commissioned.
Full removal of the monorepo child packages structure.
This commit fixes all imports paths that were broken after merging the monorepo packages togther. It then wires up a new and fully functional single package.json for the entire project, which replaces the package.json's that were in the monorepo packages. All package.json scripts included are functional, which means tests are passing and bundles are being built. Note: `npm run deploy` has intentionally been left out for now since our deployment process is going to change quite significantly.
Not really needed and is interfering with `npm install`'s of Apollo Client into applications.
Looks a little better when the bundle is referred to in stacktraces.
Everyhing we need (for now) has been moved elsewhere.
jbaxleyiii
reviewed
Sep 10, 2019
jbaxleyiii
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
@hwillson I really appreciate the commit by commit grouping that you did here, it made the review quite easy. This looks great to me and I think we should land it asap so @benjamn and @JakeDawkins can begin working on top of it
|
As an interested bystander, what are some of the reasons for this move? It seems to me that tight coupling between package changes will still be desireable? |
This reverts my previous PR #4538, now that siddharthkp/bundlesize#260 has been merged and published to npm.
benjamn
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
This PR is a huge testament to your code wrangling skills @hwillson, and also to the value of TypeScript, without which it would be so much harder to know that everything still works as it did before. Thanks for splitting everything up so cleanly!
I have one important change to request (see below), but I can push that one-line commit myself.
This saves 1.1KB of minified+gzip code, and I believe it aligns with our goals of consolidating the parts of apollo-utilities that we actually use into the combined @apollo/client package. More explanation in this comment: #5292 (comment)
StephenBarlow
pushed a commit
that referenced
this pull request
Oct 1, 2019
This saves 1.1KB of minified+gzip code, and I believe it aligns with our goals of consolidating the parts of apollo-utilities that we actually use into the combined @apollo/client package. More explanation in this comment: #5292 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents a first pass at removing Apollo Client's monorepo structure. For Apollo Client 3.0 we're moving away from using lerna and a monorepo based structure / deployment approach, to reduce complexity, better integrate project internals, and pave the way to better leverage modern build tooling capabilities.
This PR should be seen as a starting point for the new structure, not the endpoint. There are still a lot of adjustments to make, but it would be great to get these structural changes in place first to serve as a basis for subsequent PR's.
Key changes in this PR:
@apollo/clientpackageshave been removed, with their contents moved alongside the rest of the Apollo Client coresrcImportant notes:
apollo-cacheandapollo-cache-inmemorypackages have been moved intosrc/cache/coreandsrc/cache/inmemoryrespectively, but these locations can be considered temporary. There are many cache changes coming for AC 3 that will likely require re-adjusting this structure.apollo-utilitieswas moved intosrc/utilities. We already have asrc/utilsdirectory, so this duplication seems odd. I've left things like this for now, as we're going to be re-visiting all of the utilities included with Apollo Client, to decide what stays in place, and what gets moved into@apollo/graphql.The changes in this PR (and everything in
release-3.0) have been published as@apollo/client@alpha.