draft: fix(UriVariable): fix string being cast to int #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreRebeilleau
force-pushed
the
fix/composite-identifiers
branch
2 times, most recently
from
2ab609b
to
c1a1fbc
Compare
PierreRebeilleau
force-pushed
the
fix/composite-identifiers
branch
from
c1a1fbc
to
9177449
Compare
|
try to reproduce the issue at #5396 first, I don't think that an Integer IntegerUriVariableTransformer should transform something to a string. We probably don't even need to transform it if it's a string in the UriVariablesResolverTrait. |
helyakin
reviewed
Apr 7, 2023
Comment on lines
-92
to
+94
| // if ($metadata) { | ||
| // return (new class extends HttpOperation {})->withResource($metadata); | ||
| // } | ||
| // if ($metadata) { | ||
| // return (new class extends HttpOperation {})->withResource($metadata); | ||
| // } |
There was a problem hiding this comment.
Hey @PierreRebeilleau, remember me ? ;)
I think this has nothing to do with your PR. So maybe I'm wrong but you might have to revert it.
I actually thought of doing a dedicated PR for this because it affect all the created branch
There was a problem hiding this comment.
I already did that this needs rebase
There was a problem hiding this comment.
Hey @MarvinCourcier , yes i remember you ! Glad to see you around, ty i'm gonna rebase :)
PierreRebeilleau
changed the title
PierreRebeilleau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing multiple UriVariables, it is possible that a string, such as a key, could be cast to an integer (e.g., '73foo'). To avoid any potential issues, a check is performed before the cast as a workaround.