fix(metadata): fix string being cast to int

api-platform · Apr 3, 2023 · 9177449 · 9177449
1 parent 6157332
commit 9177449
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/Api/UriVariableTransformer/IntegerUriVariableTransformer.php b/src/Api/UriVariableTransformer/IntegerUriVariableTransformer.php
@@ -18,9 +18,9 @@
 
 final class IntegerUriVariableTransformer implements UriVariableTransformerInterface
 {
-    public function transform(mixed $value, array $types, array $context = []): int
+    public function transform(mixed $value, array $types, array $context = []): int|string
     {
-        return (int) $value;
+        return is_numeric($value) ? (int) $value : $value;
     }
 
     public function supportsTransformation(mixed $value, array $types, array $context = []): bool

diff --git a/src/Metadata/Resource/ResourceMetadataCollection.php b/src/Metadata/Resource/ResourceMetadataCollection.php
@@ -89,9 +89,9 @@ public function getOperation(?string $operationName = null, bool $forceCollectio
         }
 
         // Idea:
-//         if ($metadata) {
-//             return (new class extends HttpOperation {})->withResource($metadata);
-//         }
+        //         if ($metadata) {
+        //             return (new class extends HttpOperation {})->withResource($metadata);
+        //         }
 
         $this->handleNotFound($operationName, $metadata);
     }

diff --git a/tests/Api/UriVariableTransformer/IntegerUriVariableTransformerTest.php b/tests/Api/UriVariableTransformer/IntegerUriVariableTransformerTest.php
@@ -23,6 +23,11 @@ public function testTransform(): void
         $this->assertSame(2, (new IntegerUriVariableTransformer())->transform('2', ['int']));
     }
 
+    public function testCastString(): void
+    {
+        $this->assertSame('7foo', (new IntegerUriVariableTransformer())->transform('7foo', ['int']));
+    }
+
     public function testSupportsTransformation(): void
     {
         $normalizer = new IntegerUriVariableTransformer();