Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): no deprecation when elasticsearch is null #5499

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Mar 24, 2023

Q A
Branch? 3.1
Tickets #...
License MIT
Doc PR api-platform/docs#...

Related to #5450. Now fixed for non graphql operations.

@soyuka
Copy link
Member

soyuka commented Mar 27, 2023

Looks like the Behat CI for ES in unhappy witht he changes

@dannyvw
Copy link
Contributor Author

dannyvw commented Mar 27, 2023

@soyuka I think the provider is not set anymore https://github.com/api-platform/core/blob/main/src/Elasticsearch/Metadata/Resource/Factory/ElasticsearchProviderResourceMetadataCollectionFactory.php#L63. I could add this in the testcases, but not sure if that is the right way. The provider is set when ES is true.

@soyuka soyuka merged commit aa2dfe7 into api-platform:3.1 Mar 31, 2023
@soyuka
Copy link
Member

soyuka commented Mar 31, 2023

thanks @dannyvw !

@soyuka
Copy link
Member

soyuka commented Mar 31, 2023

My bad I reverted it was still red. I cannot reopen, maybe we can discuss this at #5497

@dannyvw dannyvw deleted the es-index branch March 31, 2023 17:40
@dannyvw
Copy link
Contributor Author

dannyvw commented Mar 31, 2023

This pipeline is indeed red and it is something else than #5497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants