fix(metadata): no deprecation when elasticsearch is null (#5499)

api-platform · Mar 31, 2023 · aa2dfe7 · aa2dfe7
1 parent 871824c
commit aa2dfe7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...arch/Metadata/Resource/Factory/ElasticsearchProviderResourceMetadataCollectionFactory.php b/...arch/Metadata/Resource/Factory/ElasticsearchProviderResourceMetadataCollectionFactory.php
@@ -52,7 +52,7 @@ public function create(string $resourceClass): ResourceMetadataCollection
                             : 'You will have to remove it when upgrading to v4';
                         trigger_deprecation('api-platform/core', '3.1', sprintf('Setting "elasticsearch" in Operation is deprecated. %s', $solution));
                     }
-                    if ($this->hasIndices($operation)) {
+                    if (null !== $elasticsearch && $this->hasIndices($operation)) {
                         $operation = $operation->withElasticsearch(true);
                     }
 

diff --git a/.../Metadata/Resource/Factory/ElasticsearchProviderResourceMetadataCollectionFactoryTest.php b/.../Metadata/Resource/Factory/ElasticsearchProviderResourceMetadataCollectionFactoryTest.php
@@ -95,7 +95,7 @@ public function elasticsearchProvider(): array
     {
         return [
             'elasticsearch: false' => [false, 0, false],
-            'elasticsearch: null' => [null, 1, false],
+            'elasticsearch: null' => [null, 0, false],
             'elasticsearch: true' => [true, 1, true],
         ];
     }