Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default cases in quint match expressions #2792

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

shonfeder
Copy link
Contributor

@shonfeder shonfeder commented Dec 1, 2023

This is a followup to #2783, which omitted support for the "wildcard",
default match case in match expressions.

I found this problem when checking the Paxos spec in the quint repo. In
addition to the unit test added here, I've verified that this solves the problem
on a few quint specs locally. Integration tests confirming this will be
forthcoming in the quint repo.


  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

This is a followup to #2783, which omitted support for the "wildcard",
default match case in match expressions.
@shonfeder shonfeder requested a review from Kukovec as a code owner December 1, 2023 21:40
@shonfeder shonfeder changed the title Add support for default cases in match expressions Add support for default cases in quint match expressions Dec 1, 2023
@shonfeder shonfeder requested a review from bugarela December 1, 2023 21:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (30fe7d4) 78.86% compared to head (d906595) 78.84%.

❗ Current head d906595 differs from pull request most recent head 0bca067. Consider uploading reports for the commit 0bca067 to get more accurate results

Files Patch % Lines
...ain/scala/at/forsyte/apalache/io/quint/Quint.scala 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2792      +/-   ##
==========================================
- Coverage   78.86%   78.84%   -0.02%     
==========================================
  Files         466      466              
  Lines       15921    15923       +2     
  Branches     2592     2557      -35     
==========================================
- Hits        12556    12555       -1     
- Misses       3365     3368       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bugarela bugarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Gabriela Moreira <gabrielamoreiramafra@gmail.com>
@shonfeder shonfeder enabled auto-merge December 1, 2023 22:09
@shonfeder shonfeder merged commit 67cb5ff into main Dec 1, 2023
10 checks passed
@shonfeder shonfeder deleted the shon/fix-wildard-match branch December 1, 2023 22:46
@apalache-bot apalache-bot mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants