Support quint sum types #2783
Merged
Support quint sum types #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
=======================================
Coverage 78.83% 78.83%
=======================================
Files 466 466
Lines 15905 15921 +16
Branches 2572 2592 +20
=======================================
+ Hits 12539 12552 +13
- Misses 3366 3369 +3 ☔ View full report in Codecov by Sentry. |
konnov
reviewed
Nov 27, 2023
tla-io/src/main/scala/at/forsyte/apalache/io/quint/QuintTypeConverter.scala
Outdated
Show resolved
Hide resolved
tla-io/src/test/scala/at/forsyte/apalache/io/quint/TestQuintEx.scala
Outdated
Show resolved
Hide resolved
tlair/src/main/scala/at/forsyte/apalache/tla/lir/TlaType1.scala
Outdated
Show resolved
Hide resolved
tlair/src/test/scala/at/forsyte/apalache/tla/typecomp/TestFunBuilder.scala
Outdated
Show resolved
Hide resolved
added 13 commits
November 29, 2023 19:25
This gives us tests for supporting sum type conversions into apalache.
Also removes deprecated union types
There is no reason to enforce this bit of surface syntactic trivia on the AST level, and it imposes needless overhead in the quint conversion. We enforce this in parser for the Apalache type annotations, and that should suffice.
This gives us much more context when error conversion goes wrong due to an operator we expect to be defined missing an entry in the lookup table.
Used as the unit type in quint, and causes no problems when used in this way.
This reverts commit fc88f06. We need to wait on updating this fixture until we have informalsystems/quint#1278 in place, so we can generate the correct, flattened fixtures.
shonfeder
force-pushed
the
quint/1034/sum-types
branch
from
fb09e36 to
8fe7379
Compare
4 tasks
bugarela
approved these changes
Nov 30, 2023
Co-authored-by: Gabriela Moreira <gabrielamoreiramafra@gmail.com>
shonfeder
pushed a commit
that referenced
this pull request
Dec 1, 2023
This is a followup to #2783, which omitted support for the "wildcard", default match case in match expressions.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes informalsystems/quint#1034
(thanks to informalsystems/quint#1276).
This adds support for conversion of the following quint constructs:
variantoperatormatchVariantoperatorA notable change made to support this work was relaxing the rules of the builder library to allow constructing empty records and record types. This is a meaningful value and a well formed type, and is the current choice for the unit type in quint, used for variants that don't take a value with any information (e.g., the
Aintype T = A | B(int)).This takes us ~75% of the way to full support for quint sum types, and enables
running
verifyonhttps://github.com/informalsystems/quint/blob/main/examples/language-features/option.qnt
What remains to do:
declarations. See Support user-defined polymorphic type constructors informalsystems/quint#1073
I expect reviewing by commit is helpful, as they are logically isolated.
Thanks due to @bugarela, who found this problem and was a huge help in debugging.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionality