Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUTLASS] Refactor GEMM generator in preparation for conv2d #9571

Merged
merged 4 commits into from
Nov 25, 2021
Merged

[CUTLASS] Refactor GEMM generator in preparation for conv2d #9571

merged 4 commits into from
Nov 25, 2021

Conversation

masahi
Copy link
Member

@masahi masahi commented Nov 24, 2021 •
edited
Loading

This simply moves profiling-related code in gen_gemm.py to gen_tensor_op.py, so that they can also be used from the conv2d generator.

cc @comaniac

@masahi
split non-gemm specific generator code to gen_tensor_op.py
f30ce2b 
commit 250f915
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:44:52 2021 +0900

    remove conv2d stuff

commit 1a6b27c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:41:31 2021 +0900

    remove unused import

commit f7c3b5a
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:37:07 2021 +0900

    add profiler boilarplate for conv2d

commit ca1ae27
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:22:06 2021 +0900

    introduce gen_tensor_op.py

commit 37bb918
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:45:41 2021 +0900

    more conv2d code

commit 5c00398
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:13:30 2021 +0900

    Begin conv2d support
@masahi
fix
df1946b
@masahi
use functools.partial
347adf5
@masahi masahi force-pushed the cutlass-tensor-op-refactor branch from a1db3c0 to 3698252 Compare November 24, 2021 01:28
@masahi
Copy link
Member Author

masahi commented Nov 25, 2021

@comaniac should be ready to merge

comaniac
comaniac approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor LGTM. Looking forward to seeing the Conv2D implementation :)

@comaniac comaniac merged commit adf560e into apache:main Nov 25, 2021
@comaniac
Copy link
Contributor

Thanks @masahi

dchauhan-arm pushed a commit to dchauhan-arm/tvm that referenced this pull request Nov 29, 2021
@masahi @dchauhan-arm
[CUTLASS] Refactor GEMM generator in preparation for conv2d (apache#9571
c9f6aeb 
)

* split non-gemm specific generator code to gen_tensor_op.py

commit 250f915
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:44:52 2021 +0900

    remove conv2d stuff

commit 1a6b27c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:41:31 2021 +0900

    remove unused import

commit f7c3b5a
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:37:07 2021 +0900

    add profiler boilarplate for conv2d

commit ca1ae27
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:22:06 2021 +0900

    introduce gen_tensor_op.py

commit 37bb918
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:45:41 2021 +0900

    more conv2d code

commit 5c00398
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:13:30 2021 +0900

    Begin conv2d support

* fix

* use functools.partial

* remove unused import
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
@masahi @mehrdadh
[CUTLASS] Refactor GEMM generator in preparation for conv2d (apache#9571
0758def 
)

* split non-gemm specific generator code to gen_tensor_op.py

commit 250f915
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:44:52 2021 +0900

    remove conv2d stuff

commit 1a6b27c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:41:31 2021 +0900

    remove unused import

commit f7c3b5a
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:37:07 2021 +0900

    add profiler boilarplate for conv2d

commit ca1ae27
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:22:06 2021 +0900

    introduce gen_tensor_op.py

commit 37bb918
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:45:41 2021 +0900

    more conv2d code

commit 5c00398
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:13:30 2021 +0900

    Begin conv2d support

* fix

* use functools.partial

* remove unused import
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
@masahi @mehrdadh
[CUTLASS] Refactor GEMM generator in preparation for conv2d (apache#9571
7fb3542 
)

* split non-gemm specific generator code to gen_tensor_op.py

commit 250f915
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:44:52 2021 +0900

    remove conv2d stuff

commit 1a6b27c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:41:31 2021 +0900

    remove unused import

commit f7c3b5a
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:37:07 2021 +0900

    add profiler boilarplate for conv2d

commit ca1ae27
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:22:06 2021 +0900

    introduce gen_tensor_op.py

commit 37bb918
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:45:41 2021 +0900

    more conv2d code

commit 5c00398
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:13:30 2021 +0900

    Begin conv2d support

* fix

* use functools.partial

* remove unused import
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@masahi @ylc
[CUTLASS] Refactor GEMM generator in preparation for conv2d (apache#9571
d8f1eb3 
)

* split non-gemm specific generator code to gen_tensor_op.py

commit 250f915
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:44:52 2021 +0900

    remove conv2d stuff

commit 1a6b27c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:41:31 2021 +0900

    remove unused import

commit f7c3b5a
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:37:07 2021 +0900

    add profiler boilarplate for conv2d

commit ca1ae27
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:22:06 2021 +0900

    introduce gen_tensor_op.py

commit 37bb918
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:45:41 2021 +0900

    more conv2d code

commit 5c00398
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:13:30 2021 +0900

    Begin conv2d support

* fix

* use functools.partial

* remove unused import
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
@masahi @yangulei
[CUTLASS] Refactor GEMM generator in preparation for conv2d (apache#9571
eb044dc 
)

* split non-gemm specific generator code to gen_tensor_op.py

commit 250f915
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:44:52 2021 +0900

    remove conv2d stuff

commit 1a6b27c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:41:31 2021 +0900

    remove unused import

commit f7c3b5a
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:37:07 2021 +0900

    add profiler boilarplate for conv2d

commit ca1ae27
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:22:06 2021 +0900

    introduce gen_tensor_op.py

commit 37bb918
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:45:41 2021 +0900

    more conv2d code

commit 5c00398
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:13:30 2021 +0900

    Begin conv2d support

* fix

* use functools.partial

* remove unused import
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
@masahi @yangulei
[CUTLASS] Refactor GEMM generator in preparation for conv2d (apache#9571
3202cfb 
)

* split non-gemm specific generator code to gen_tensor_op.py

commit 250f915
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:44:52 2021 +0900

    remove conv2d stuff

commit 1a6b27c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:41:31 2021 +0900

    remove unused import

commit f7c3b5a
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:37:07 2021 +0900

    add profiler boilarplate for conv2d

commit ca1ae27
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:22:06 2021 +0900

    introduce gen_tensor_op.py

commit 37bb918
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:45:41 2021 +0900

    more conv2d code

commit 5c00398
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:13:30 2021 +0900

    Begin conv2d support

* fix

* use functools.partial

* remove unused import
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@masahi @ylc
[CUTLASS] Refactor GEMM generator in preparation for conv2d (apache#9571
cb3a609 
)

* split non-gemm specific generator code to gen_tensor_op.py

commit 250f915
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:44:52 2021 +0900

    remove conv2d stuff

commit 1a6b27c
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:41:31 2021 +0900

    remove unused import

commit f7c3b5a
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:37:07 2021 +0900

    add profiler boilarplate for conv2d

commit ca1ae27
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 06:22:06 2021 +0900

    introduce gen_tensor_op.py

commit 37bb918
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:45:41 2021 +0900

    more conv2d code

commit 5c00398
Author: Masahiro Masuda <masahi129@gmail.com>
Date:   Sun Nov 14 05:13:30 2021 +0900

    Begin conv2d support

* fix

* use functools.partial

* remove unused import
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@areusch areusch Awaiting requested review from areusch

@icemelon icemelon Awaiting requested review from icemelon

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@merrymercy merrymercy Awaiting requested review from merrymercy

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masahi @comaniac