fix topi c++ conv2d_nchw lambda expr issue #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
reviewed
Jul 18, 2019
| @@ -268,7 +268,7 @@ inline tvm::Tensor conv2d_nchw(const tvm::Tensor& I, | |||
| : pad(I, {tvm::Expr(0), tvm::Expr(0), pad_h, pad_w}); | |||
| auto l = [&](tvm::Var b, tvm::Var o, tvm::Var h, tvm::Var w) { | |||
| return tvm::sum( | |||
| T(b, i, stride_h * h + kh, stride_w * w + kw) * W(i, o, kh, kw), | |||
| T(b, i, stride_h * h + kh, stride_w * w + kw) * W(o, i, kh, kw), | |||
There was a problem hiding this comment.
Do we have any test case for conv2d cpp implementation?
There was a problem hiding this comment.
Sorry, no test conv2d cpp implementation there.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weight tensor's usage should be
W(o, i, kh, kw)fix #3562