Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOPI][C++]conv2d_nchw mistake? #3562

Closed
zacario-li opened this issue Jul 17, 2019 · 1 comment · Fixed by #3570
Closed

[TOPI][C++]conv2d_nchw mistake? #3562

zacario-li opened this issue Jul 17, 2019 · 1 comment · Fixed by #3570
Labels
status: help wanted

Comments

@zacario-li
Copy link
Contributor

zacario-li commented Jul 17, 2019 •
edited
Loading

Hi,
file: topi/include/topi/nn.h
conv2d_nchw()
T(b, i, stride_h * h + kh, stride_w * w + kw) * W(i, o, kh, kw)
I think W(i, o, kh, kw) should be W(o, i, kh, kw), am I right?

@ashokei
@tqchen
Copy link
Member

tqchen commented Jul 17, 2019

This seems to be indeed a mistake. @zacario-li can you send in a patch?

@zacario-li zacario-li mentioned this issue Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix topi c++ conv2d_nchw lambda expr issue zacario-li/tvm
2 participants
@tqchen @zacario-li