#1592 [PASS] Fix missing mem CHECK in storage_rewrite #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_num_bits' too small, it will cause fatal error
…_num_bits' too small, it will cause mem exceed error, add test case 'test_exceed_mem()'
… triggered by 'max_num_bits < 640'. The CHECK_LE func is also added in L587.
|
please fix the testcase so that they pass, if you expect an throw, do try catch and assert False if theprogram pass |
xqdan
changed the title
tqchen
approved these changes
Aug 18, 2018
|
Thanks @xqdan ! this is now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1592
The test case "test_mem_exceed()" in the file "test_pass_storage_rewrite.py" is made to show the bug of "allocation exceed bound of memory".
In our tests, if max_num_bits < 640, it will trigger the bug.
The CHECK_LE function is added in the file "storage_rewrite.cc L587". After that, the test case "test_alloc_seq()" and "test_alloc_seq_type2()" in the file "test_pass_storage_rewrite.py" are fixed by adding the memory register function.
Regards.