Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pass] Missing CHECK in storage rewrite #1592

Closed
xqdan opened this issue Aug 13, 2018 · 4 comments
Closed

[Pass] Missing CHECK in storage rewrite #1592

xqdan opened this issue Aug 13, 2018 · 4 comments

Comments

@xqdan
Copy link
Contributor

xqdan commented Aug 13, 2018

We have a complicated case triggering this bug.

after L586, we should have the same check as L559
https://github.com/dmlc/tvm/blob/master/src/pass/storage_rewrite.cc#L559
@tqchen
Copy link
Member

tqchen commented Aug 13, 2018

Can you send a PR?

@tqchen tqchen removed the type: bug label Aug 14, 2018
@tqchen
Copy link
Member

tqchen commented Aug 14, 2018

also, please clarify if this is a bug, or a guard that need to be added to the case

@xqdan
Copy link
Contributor Author

xqdan commented Aug 14, 2018

Sure, short cut case may take some time

@xqdan xqdan mentioned this issue Aug 17, 2018
Merged
tqchen pushed a commit that referenced this issue Aug 18, 2018
@xqdan @tqchen
#1592 [PASS] Fix missing mem CHECK in storage_rewrite (#1616)
38d0835
@xqdan
Copy link
Contributor Author

xqdan commented Aug 19, 2018

fixed by #1616

@xqdan xqdan closed this as completed Aug 19, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this issue Dec 27, 2018
@xqdan @tqchen
apache#1592 [PASS] Fix missing mem CHECK in storage_rewrite (apache#1616
d7df07f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yzhliu @tqchen @xqdan