Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR] [Analysis] Calculate allocated memory at module level #14711
[TIR] [Analysis] Calculate allocated memory at module level #14711
Changes from all commits
ee72601
794274c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether "throw" is required here? LogFatal throws InternalError.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I actually saw multiple places within the codebase which had
throw
after aLOG(FATAL)
. I looked into the code and see that theInternalError
is thrown from the call toLogFatalImpl
.As far as I can tell,
LogFatalImpl
can be overridden by targets, so maybe that's why the throws are needed as we can't know for sure whether all implementations ofLOG(FATAL)
would throw InternalError. I'm not completely sure about this, but this is my understanding from looking at the code.Would love to know if you had any more insights and am happy to remove the throw if you think it's not needed, thanks.