[TIR] [Analysis] Calculate allocated memory at module level #14711
Conversation
This patch modifies the existing analysis pass `tir.calculate_allocated_bytes` to accept an IRModule as an argument and return allocated bytes for all prim_funcs in the IRModule.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
| } else { | ||
| LOG(FATAL) << "TypeError: Expect the input to be either PrimFunc or IRModule, but gets: " | ||
| << obj->GetTypeKey(); | ||
| throw; |
There was a problem hiding this comment.
Whether "throw" is required here? LogFatal throws InternalError.
There was a problem hiding this comment.
Thanks for the suggestion. I actually saw multiple places within the codebase which had throw after a LOG(FATAL). I looked into the code and see that the InternalError is thrown from the call to LogFatalImpl.
As far as I can tell, LogFatalImpl can be overridden by targets, so maybe that's why the throws are needed as we can't know for sure whether all implementations of LOG(FATAL) would throw InternalError. I'm not completely sure about this, but this is my understanding from looking at the code.
Would love to know if you had any more insights and am happy to remove the throw if you think it's not needed, thanks.
This patch modifies the existing analysis pass
tir.calculate_allocated_bytesto accept an IRModule as an argument and return allocated bytes for all prim_funcs in the IRModule.