Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Downgrade ci_cpu llvm version back to 11 #14680

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

neildhickey
Copy link
Contributor

The upgrade to llvm 15 caused failures in topi tests python/topi/python/test_topi_math.py::test_cast[float64-float16-llvm]. It seems to be a miscompilation due to opaque pointers. Downgrading while working to fix the issue.

The upgrade to llvm 15 caused failures in topi tests python/topi/python/test_topi_math.py::test_cast[float64-float16-llvm].
It seems to be a miscompilation due to opaque pointers.
Downgrading while working to fix the issue.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 20, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@neildhickey neildhickey changed the title [CI] Downgrade ci_cpu llvm version back to 11. [CI] Downgrade ci_cpu llvm version back to 11 Apr 20, 2023
@ekalda
Copy link
Contributor

ekalda commented Apr 20, 2023

@tvm-bot rerun

@yongwww
Copy link
Member

yongwww commented Apr 20, 2023

@neildhickey thanks for the investigation! I saw this issue in my ci upgrade work (#14651), it would better to fix this cast issue, looks the cast from f64 to f16 generates wrong result.

@neildhickey
Copy link
Contributor Author

@yongwww Yes I do want to fix the issue properly but put up this patch as a temporary work around until I am able to fix it properly

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it @neildhickey

@leandron leandron merged commit 41ae745 into apache:main Apr 20, 2023
@leandron
Copy link
Contributor

Merging this to make the current ci_cpu image sources to work again.

@neildhickey neildhickey deleted the llvm-11-downgrade-ci-cpu branch April 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants