Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Modify test cases to accommodate the CI upgrades #14651

Merged
merged 30 commits into from
May 5, 2023

Conversation

yongwww
Copy link
Member

@yongwww yongwww commented Apr 18, 2023

update with the images built from #14635

Co-authored by @driazati

@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 18, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@leandron leandron mentioned this pull request Apr 18, 2023
@yongwww yongwww force-pushed the ci_main_images_upgrade branch 3 times, most recently from 7ed271c to 9561770 Compare April 24, 2023 05:36
@yongwww yongwww changed the title [WIP][CI] update all the images and test cases [WIP][CI] Update test cases with new upgraded dockers Apr 24, 2023
@yongwww yongwww changed the title [WIP][CI] Update test cases with new upgraded dockers [WIP][CI] Update test cases with newly upgraded dockers Apr 24, 2023
@yongwww yongwww force-pushed the ci_main_images_upgrade branch 3 times, most recently from c0654f5 to 45fe044 Compare April 26, 2023 15:50
@yongwww yongwww changed the title [WIP][CI] Update test cases with newly upgraded dockers [CI] Modify test cases to accommodate the CI upgrades Apr 26, 2023
@yongwww
Copy link
Member Author

yongwww commented Apr 27, 2023

It is ready for review now, CI is supposed to be green soon. cc: @tqchen @masahi

@yongwww yongwww changed the title [CI] Modify test cases to accommodate the CI upgrades [DO NOT MERGE][CI] Modify test cases to accommodate the CI upgrades Apr 27, 2023
@tqchen
Copy link
Member

tqchen commented May 3, 2023

@yongwww please resolve the conflict

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI, thanks for putting all the work to update dependencies.

Can you clarify, before we merge this PR, what is the plan to get these changes in with properly named Docker images, not development image names such as 477529581014.dkr.ecr.us-west-2.amazonaws.com/ci_***:PR-14635-40ebeb599-30?

@tqchen
Copy link
Member

tqchen commented May 3, 2023

The CI is green now. Based on what I read, there is a inter dep between changing the docker name and properly build and upload the images to the dockerhub.

I assume once we merged the docker part and images get uploaded, it would be as simple as change the images to the right one and it can be done quickly.

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is green now. Based on what I read, there is a inter dep between changing the docker name and properly build and upload the images to the dockerhub.

I assume once we merged the docker part and images get uploaded, it would be as simple as change the images to the right one and it can be done quickly.

I'm happy to proceed with any plan that doesn't leave the sources in an inconsistent state for more than a few minutes/hours.

Do you have a suggestion in terms of a sequence of steps to coordinate this PR and #14635?

@yongwww
Copy link
Member Author

yongwww commented May 3, 2023

@leandron I am following the steps to upgrade the CI. I assume the upgraded images will be built and uploaded into tlcpackstaging after #14635 lands, then I just need to update ci/jenkins/docker-images.ini in this PR to point to the expected newly generated images.

@yongwww yongwww changed the title [DO NOT MERGE][CI] Modify test cases to accommodate the CI upgrades [CI] Modify test cases to accommodate the CI upgrades May 4, 2023
@yongwww
Copy link
Member Author

yongwww commented May 5, 2023

The docker images built from the ci upgrade #14635 have been automatically uploaded to tlcpackstaging. In this pr, I have modified the docker-images.ini to point to those newly uploaded images, and CI is green now. Please take a look and help land it if there are no further change requests. cc: @tqchen @leandron @masahi @driazati

@leandron leandron merged commit aa7d2bf into apache:main May 5, 2023
@leandron
Copy link
Contributor

leandron commented May 5, 2023

Thanks @yongwww @tqchen, this is now merged, thanks for the great work!

@yongwww yongwww deleted the ci_main_images_upgrade branch May 5, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants