-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Modify test cases to accommodate the CI upgrades #14651
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
dbd1a95
to
27e9a36
Compare
7ed271c
to
9561770
Compare
c0654f5
to
45fe044
Compare
@yongwww please resolve the conflict |
006e664
to
5f8563c
Compare
c57fe76
to
5939d48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI, thanks for putting all the work to update dependencies.
Can you clarify, before we merge this PR, what is the plan to get these changes in with properly named Docker images, not development image names such as 477529581014.dkr.ecr.us-west-2.amazonaws.com/ci_***:PR-14635-40ebeb599-30
?
The CI is green now. Based on what I read, there is a inter dep between changing the docker name and properly build and upload the images to the dockerhub. I assume once we merged the docker part and images get uploaded, it would be as simple as change the images to the right one and it can be done quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is green now. Based on what I read, there is a inter dep between changing the docker name and properly build and upload the images to the dockerhub.
I assume once we merged the docker part and images get uploaded, it would be as simple as change the images to the right one and it can be done quickly.
I'm happy to proceed with any plan that doesn't leave the sources in an inconsistent state for more than a few minutes/hours.
Do you have a suggestion in terms of a sequence of steps to coordinate this PR and #14635?
The docker images built from the ci upgrade #14635 have been automatically uploaded to tlcpackstaging. In this pr, I have modified the docker-images.ini to point to those newly uploaded images, and CI is green now. Please take a look and help land it if there are no further change requests. cc: @tqchen @leandron @masahi @driazati |
update with the images built from #14635
Co-authored by @driazati