Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix build android rpc failure in CI #12216

Merged
merged 2 commits into from
Jul 29, 2022
Merged

[CI] Fix build android rpc failure in CI #12216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c1109
Fix environment variable to support current version of virtual-enviro…
valmat07 Jul 28, 2022
2ad82a8
Add unbound variable tracking for android_rpc
valmat07 Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ jobs:
- name: Build android_rpc
working-directory: apps/android_rpc
run: |
export PATH="${ANDROID_NDK_HOME}:$PATH"
set -eux
export PATH="${ANDROID_NDK_LATEST_HOME}:$PATH"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add set -eux to all the inline scripts so we get errors about unbound variables if something changes in the future?

gradle clean build
- name: Upload android_rpc APK
uses: actions/upload-artifact@v2
Expand All @@ -132,7 +133,8 @@ jobs:
- name: Build android_deploy
working-directory: apps/android_deploy
run: |
export PATH="${ANDROID_NDK_HOME}:$PATH"
set -eux
export PATH="${ANDROID_NDK_LATEST_HOME}:$PATH"
gradle clean build
- name: Upload android_deploy APK
uses: actions/upload-artifact@v2
Expand All @@ -142,8 +144,9 @@ jobs:
- name: Build android_camera
working-directory: apps/android_camera
run: |
set -eux
mkdir -p app/src/main/assets/models/
export TVM_NDK_CC=${ANDROID_NDK_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android30-clang++
export TVM_NDK_CC=${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android30-clang++
export TVM_HOME=~/work/tvm/tvm
export PYTHONPATH=$TVM_HOME/python:${PYTHONPATH}
python3 ${TVM_HOME}/python/gen_requirements.py
Expand All @@ -152,7 +155,7 @@ jobs:
pip3 install -r requirements.txt
python3 prepare_model.py
cd ..
export PATH="${ANDROID_NDK_HOME}:$PATH"
export PATH="${ANDROID_NDK_LATEST_HOME}:$PATH"
gradle clean build
- name: Upload android_camera APK
uses: actions/upload-artifact@v2
Expand Down