[CI] Fix build android rpc failure in CI #12216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
reviewed
Jul 28, 2022
| @@ -122,7 +122,7 @@ jobs: | |||
| - name: Build android_rpc | |||
| working-directory: apps/android_rpc | |||
| run: | | |||
| export PATH="${ANDROID_NDK_HOME}:$PATH" | |||
| export PATH="${ANDROID_NDK_LATEST_HOME}:$PATH" | |||
There was a problem hiding this comment.
Can you also add set -eux to all the inline scripts so we get errors about unbound variables if something changes in the future?
valmat07
added a commit
to Deelvin/tvm
that referenced
this pull request
Jul 29, 2022
This reverts commit e7e29b4.
valmat07
added a commit
to Deelvin/tvm
that referenced
this pull request
Aug 2, 2022
This reverts commit e7e29b4.
driazati
pushed a commit
that referenced
this pull request
Aug 2, 2022
Reverts #12216 Addition to my previous changes. After the previous changes, the android camera build failed because by default `PYTHONPATH` is empty, and after `set -eux` it is fails: https://github.com/apache/tvm/blob/759a648cd5237885a8205b1ee4508dabcc3af2d5/.github/workflows/main.yml#L152-L156 This error was not noticed because the flag `continue-on-error` is true.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
android_rpc build problem: apache#12191 The problem with the build appeared due to the fact that the `ANDROID_NDK_HOME` environment variable was removed in the current version of github actions. https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md But this variable is used here: https://github.com/apache/tvm/blob/ee319d9d23c80091da9c4fb764b1e6d49d462714/.github/workflows/main.yml#L122-L127 Now only `ANDROID_NDK_LATEST_HOME` is available for ndk.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Reverts apache#12216 Addition to my previous changes. After the previous changes, the android camera build failed because by default `PYTHONPATH` is empty, and after `set -eux` it is fails: https://github.com/apache/tvm/blob/759a648cd5237885a8205b1ee4508dabcc3af2d5/.github/workflows/main.yml#L152-L156 This error was not noticed because the flag `continue-on-error` is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
android_rpc build problem: #12191
The problem with the build appeared due to the fact that the
ANDROID_NDK_HOMEenvironment variable was removed in the current version of github actions.https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md
But this variable is used here:
tvm/.github/workflows/main.yml
Lines 122 to 127 in ee319d9
Now only
ANDROID_NDK_LATEST_HOMEis available for ndk.cc @Mousius @areusch @driazati