Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash caused by a HTTP/2 GET request with a body #9738

Merged
merged 2 commits into from
May 25, 2023

Conversation

duke8253
Copy link
Contributor

Fix a crash caused by a HTTP/2 GET request with a body, adds a few tests with it, and update proxy verifier to 2.8.0

@duke8253 duke8253 added this to the 10.0.0 milestone May 24, 2023
@duke8253 duke8253 self-assigned this May 24, 2023
@duke8253 duke8253 force-pushed the master-h2get_with_body branch from f2f657b to 6fba6de Compare May 24, 2023 20:51
duke8253 and others added 2 commits May 24, 2023 17:02
This updates our test suite to use Proxy Verifier v2.8.0. This release
comes with HTTP/2 frame replay updates.

(cherry picked from commit 0f70092)
@duke8253 duke8253 force-pushed the master-h2get_with_body branch from 6fba6de to 4ef26cb Compare May 24, 2023 21:02
@duke8253 duke8253 merged commit 50b6aa9 into apache:master May 25, 2023
bneradt added a commit to bneradt/trafficserver that referenced this pull request Sep 8, 2023
This is a set of Proxy Verifier cherry-picks from master into 9.2.x to
get 9.2.x up to date with the latest v2.10.1 Proxy Verifier release.

---

Fix the autest Proxy Verifier version check (apache#9365)

The Proxy Verifier autest version check logic assumed that
verifier-client was in the PATH. This is most often not the case, and
even if it is it can be the wrong one since the test will by default use
the unpacked Proxy Verifier from bintray. This fixes the check so that
it explicitly refers to the verifier-client that the test will use.

(cherry picked from commit edbd10a)

Upgrade to Proxy Verifier v2.7.0 (apache#9611)

Proxy Verifier v2.7.0 adds:

* Proxy Protocol support.
* HTTP response reason string verification

Some of the h2origin AuTest tests were over-specified with respect to
reason strings. HTTP/2 explicitly removes reason strings, so they will
not be in the responses nor will the verifier client find them. This
removes those incorrect specifications.

(cherry picked from commit b449992)

Fix a crash caused by a HTTP/2 GET request with a body (apache#9738)

* fix a crash caused by a HTTP/2 GET request with a body

* Update to Proxy Verifier v2.8.0

This updates our test suite to use Proxy Verifier v2.8.0. This release
comes with HTTP/2 frame replay updates.

In the cherry-pick from master to 9.2.x, I removed the following test
updates because they were HTTP/2 to origin specific:

* h2get_with_body
* background_fill

(cherry picked from commit 0f70092)

---------

Co-authored-by: bneradt <bneradt@yahooinc.com>
(cherry picked from commit 50b6aa9)

Update to Proxy Verifier v2.8.1 (apache#9834)

Proxy Verifier v2.8.1 has fixes for the way Proxy Verifier relates to
HTTP/2 CONNECT method request pseudo header fields. This will be helpful
for testing HTTP/2 CONNECT requests.

(cherry picked from commit d5c47a7)

Proxy Verifier: update to v2.9.0 (apache#10083)

Proxy Verifier v2.9.0 adds HTTP/2 trailer support as well as containing
updates for Expect: 100-continue and quic timeout.

(cherry picked from commit 183aa3e)

Update Proxy Verifier to v2.10.1 (apache#10322)

This includes the ability to specify separate DATA frames for a stream
as well as a way to keep a session open after the final transaction.

(cherry picked from commit c5d7b19)

fix ProxyVerifier version check (apache#9267)

(cherry picked from commit a2ab0b7)
zwoop pushed a commit that referenced this pull request Sep 8, 2023
This is a set of Proxy Verifier cherry-picks from master into 9.2.x to
get 9.2.x up to date with the latest v2.10.1 Proxy Verifier release.

---

Fix the autest Proxy Verifier version check (#9365)

The Proxy Verifier autest version check logic assumed that
verifier-client was in the PATH. This is most often not the case, and
even if it is it can be the wrong one since the test will by default use
the unpacked Proxy Verifier from bintray. This fixes the check so that
it explicitly refers to the verifier-client that the test will use.

(cherry picked from commit edbd10a)

Upgrade to Proxy Verifier v2.7.0 (#9611)

Proxy Verifier v2.7.0 adds:

* Proxy Protocol support.
* HTTP response reason string verification

Some of the h2origin AuTest tests were over-specified with respect to
reason strings. HTTP/2 explicitly removes reason strings, so they will
not be in the responses nor will the verifier client find them. This
removes those incorrect specifications.

(cherry picked from commit b449992)

Fix a crash caused by a HTTP/2 GET request with a body (#9738)

* fix a crash caused by a HTTP/2 GET request with a body

* Update to Proxy Verifier v2.8.0

This updates our test suite to use Proxy Verifier v2.8.0. This release
comes with HTTP/2 frame replay updates.

In the cherry-pick from master to 9.2.x, I removed the following test
updates because they were HTTP/2 to origin specific:

* h2get_with_body
* background_fill

(cherry picked from commit 0f70092)

---------

Co-authored-by: bneradt <bneradt@yahooinc.com>
(cherry picked from commit 50b6aa9)

Update to Proxy Verifier v2.8.1 (#9834)

Proxy Verifier v2.8.1 has fixes for the way Proxy Verifier relates to
HTTP/2 CONNECT method request pseudo header fields. This will be helpful
for testing HTTP/2 CONNECT requests.

(cherry picked from commit d5c47a7)

Proxy Verifier: update to v2.9.0 (#10083)

Proxy Verifier v2.9.0 adds HTTP/2 trailer support as well as containing
updates for Expect: 100-continue and quic timeout.

(cherry picked from commit 183aa3e)

Update Proxy Verifier to v2.10.1 (#10322)

This includes the ability to specify separate DATA frames for a stream
as well as a way to keep a session open after the final transaction.

(cherry picked from commit c5d7b19)

fix ProxyVerifier version check (#9267)

(cherry picked from commit a2ab0b7)
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master:
  Fix Via header on H3 connections (apache#9758)
  Add ssrc and surc log fields for server simple/unavail retry counts. (apache#9694)
  Term standardization: dead/down server -> down server (apache#9582)
  Fix a crash caused by a HTTP/2 GET request with a body (apache#9738)
  Add configuration for UDP poll timeout (apache#9733)
  Fix quic_no_activity_timeout test (apache#9737)
  Updates to cmake install to get a running ATS from a fresh install (apache#9735)
  Make config.proxy.http.no_dns_just_forward_to_parent overridable (apache#9728)
  Fix a potential crash due to use-after-free on QUIC connections (apache#9715)
  Doc: Clarify that connect ports can have multiple values (apache#9713)
  Add BRAVO Reader-Writer Lock (apache#9394)
  Cleanup: Fix format of doc corruption message (apache#9725)
  Don't build traffic_quic command (apache#9726)
  Fix protocol version in request Via header (apache#9716)
  Fix TS_HTTP_REQUEST_TRANSFORM_HOOK Tunnel Processing (apache#9724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants