Fix TS_HTTP_REQUEST_TRANSFORM_HOOK Tunnel Processing #9724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in client request processing for transform tunnels. Without this fix, the transform request tunnel was not created for requests with a body which made it so that request transform plugins were not dispatched to for the various events concerning requests with a body.
shukitchan
reviewed
May 21, 2023
| server_txn->has_request_body(t_state.hdr_info.response_content_length, | ||
| t_state.server_info.transfer_encoding == HttpTransact::CHUNKED_ENCODING) && | ||
| server_txn->has_request_body(t_state.hdr_info.request_content_length, | ||
| t_state.client_info.transfer_encoding == HttpTransact::CHUNKED_ENCODING) && |
There was a problem hiding this comment.
Interesting. That's a typo kind of mistake here.
There was a problem hiding this comment.
Exactly. It was likely a copy and paste mistake when things got shifted around for HTTP/2 to origin. Thankfully it's an easy fix.
shukitchan
approved these changes
May 21, 2023
SolidWallOfCode
approved these changes
May 22, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: Fix Via header on H3 connections (apache#9758) Add ssrc and surc log fields for server simple/unavail retry counts. (apache#9694) Term standardization: dead/down server -> down server (apache#9582) Fix a crash caused by a HTTP/2 GET request with a body (apache#9738) Add configuration for UDP poll timeout (apache#9733) Fix quic_no_activity_timeout test (apache#9737) Updates to cmake install to get a running ATS from a fresh install (apache#9735) Make config.proxy.http.no_dns_just_forward_to_parent overridable (apache#9728) Fix a potential crash due to use-after-free on QUIC connections (apache#9715) Doc: Clarify that connect ports can have multiple values (apache#9713) Add BRAVO Reader-Writer Lock (apache#9394) Cleanup: Fix format of doc corruption message (apache#9725) Don't build traffic_quic command (apache#9726) Fix protocol version in request Via header (apache#9716) Fix TS_HTTP_REQUEST_TRANSFORM_HOOK Tunnel Processing (apache#9724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in client request processing for transform tunnels. Without this fix, the transform request tunnel was not created for requests with a body which made it so that request transform plugins were not dispatched to for the various events concerning requests with a body.