Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Phys_Location V5 apis to respond with RFC3339 date/time Format #7631

Merged

Conversation

jagan-parthiban
Copy link
Contributor

@jagan-parthiban jagan-parthiban commented Jul 11, 2023

Closes: #7630
Related: #5911


  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Make Api calls to Phys_Location 5.0

Phys_Location to Use RFC3339 Format

{
	"response": [
		{
			"address": "Buckingham Palace",
			"city": "London",
			"comments": "Buckingham Palace",
			"email": "steve.kingstone@royal.gsx.gov.uk",
			"id": 41,
			"lastUpdated": "2023-07-09T18:56:27.057163+05:30",
			"name": "New_Scot",
			"phone": "0-843-816-6276",
			"poc": "Her Majesty The Queen Elizabeth Alexandra Mary Windsor II",
			"regionId": 71,
			"region": "Scotland",
			"shortName": "new_scot",
			"state": "Westminster",
			"zip": "SW1A 1AA"
		},

	]
}

If this is a bugfix, which Traffic Control versions contained the bug?

  • 7.0.x

PR submission checklist

}

query := selectQuery() + where + orderBy + pagination
rows, err := tx.NamedQuery(query, queryValues)

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query depends on a
user-provided value
.
@jagan-parthiban jagan-parthiban added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution labels Jul 11, 2023
@jagan-parthiban jagan-parthiban marked this pull request as ready for review July 11, 2023 14:45
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #7631 (72fc6fe) into master (7316c56) will decrease coverage by 2.39%.
The diff coverage is 2.51%.

@@             Coverage Diff              @@
##             master    #7631      +/-   ##
============================================
- Coverage     32.34%   29.95%   -2.39%     
  Complexity       98       98              
============================================
  Files           762      794      +32     
  Lines         77708    84575    +6867     
  Branches        907      905       -2     
============================================
+ Hits          25137    25338     +201     
- Misses        50455    57104    +6649     
- Partials       2116     2133      +17     
Flag Coverage Δ
golib_unit 48.25% <ø> (-0.03%) ⬇️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.28% <ø> (?)
traffic_monitor_unit 21.30% <ø> (ø)
traffic_ops_integration 69.39% <100.00%> (-0.03%) ⬇️
traffic_ops_unit 22.68% <1.27%> (-0.17%) ⬇️
traffic_portal_v2 73.92% <ø> (+0.14%) ⬆️
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 27.08% <1.27%> (-2.40%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.52% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fic_ops/traffic_ops_golang/dbhelpers/db_helpers.go 21.02% <0.00%> (-0.16%) ⬇️
.../traffic_ops_golang/physlocation/phys_locations.go 10.02% <0.00%> (-21.19%) ⬇️
traffic_ops/traffic_ops_golang/routing/routes.go 95.53% <100.00%> (ø)
traffic_ops/v5-client/phys_location.go 76.66% <100.00%> (ø)

... and 43 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srijeet0406
Copy link
Contributor

Also, looks like there's a conflict in changelog.md

@jagan-parthiban
Copy link
Contributor Author

Also, looks like there's a conflict in changelog.md

Resolved Merge Conflict.

@rimashah25 rimashah25 added this to the 8.0.0 milestone Jul 17, 2023
Copy link
Contributor

@srijeet0406 srijeet0406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for fixing this!

@srijeet0406 srijeet0406 merged commit 451827f into apache:master Jul 21, 2023
42 of 44 checks passed
@jagan-parthiban jagan-parthiban deleted the improve/rfc3339-phy-location branch July 27, 2023 04:23
@jagan-parthiban jagan-parthiban restored the improve/rfc3339-phy-location branch July 27, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phys_Location in TO API uses non-RFC3339 date/time strings
3 participants