-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Phys_Location V5 apis to respond with RFC3339 date/time Format #7631
Fixes Phys_Location V5 apis to respond with RFC3339 date/time Format #7631
Conversation
d7b9add
to
05a14bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #7631 +/- ##
============================================
- Coverage 32.34% 29.95% -2.39%
Complexity 98 98
============================================
Files 762 794 +32
Lines 77708 84575 +6867
Branches 907 905 -2
============================================
+ Hits 25137 25338 +201
- Misses 50455 57104 +6649
- Partials 2116 2133 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 43 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Also, looks like there's a conflict in changelog.md |
c77db30
to
09750e0
Compare
Resolved Merge Conflict. |
dff8d5e
to
34ab843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for fixing this!
Closes: #7630
Related: #5911
What is the best way to verify this PR?
Make Api calls to Phys_Location 5.0
Phys_Location to Use RFC3339 Format
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist