Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phys_Location in TO API uses non-RFC3339 date/time strings #7630

Closed
jagan-parthiban opened this issue Jul 11, 2023 · 0 comments · Fixed by #7631
Closed

Phys_Location in TO API uses non-RFC3339 date/time strings #7630

jagan-parthiban opened this issue Jul 11, 2023 · 0 comments · Fixed by #7631
Labels
low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Comments

@jagan-parthiban
Copy link
Contributor

Parent Issue: #5911

Breaking down the parent issue #5911 in smaller issues to raise separate, reviewable PRs for each of the services.

Traffic Control components affected:

  • Traffic Ops
  • Documentation

Current behavior:

Phys_Location Using Deprecated TimeNoMod & TimeLayout

curl --request GET \
  --url https://localhost:8443/api/4.1/phys_locations


{
	"response": [
		{
			"address": "Buckingham Palace",
			"city": "London",
			"comments": "Buckingham Palace",
			"email": "steve.kingstone@royal.gsx.gov.uk",
			"id": 41,
			"lastUpdated": "2023-07-09 18:56:27+05",
			"name": "New_Scot",
			"phone": "0-843-816-6276",
			"poc": "Her Majesty The Queen Elizabeth Alexandra Mary Windsor II",
			"regionId": 71,
			"region": "Scotland",
			"shortName": "new_scot",
			"state": "Westminster",
			"zip": "SW1A 1AA"
		},
	]
}

Expected behavior:

Phys_Location to Use RFC3339 Format

curl --request GET \
  --url https://localhost:8443/api/5.0/phys_locations


{
	"response": [
		{
			"address": "Buckingham Palace",
			"city": "London",
			"comments": "Buckingham Palace",
			"email": "steve.kingstone@royal.gsx.gov.uk",
			"id": 41,
			"lastUpdated": "2023-07-09T18:56:27.057163+05:30",
			"name": "New_Scot",
			"phone": "0-843-816-6276",
			"poc": "Her Majesty The Queen Elizabeth Alexandra Mary Windsor II",
			"regionId": 71,
			"region": "Scotland",
			"shortName": "new_scot",
			"state": "Westminster",
			"zip": "SW1A 1AA"
		},

	]
}

Steps to reproduce:

Make the above api call to 4.1 version

@jagan-parthiban jagan-parthiban added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution low difficulty the estimated level of effort to resolve this issue is low labels Jul 11, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 11, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 11, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 11, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 11, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 11, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 11, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 11, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 12, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 12, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 12, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 12, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 14, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 14, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 14, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 14, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 14, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 14, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 17, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 19, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 20, 2023
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Jul 21, 2023
srijeet0406 pushed a commit that referenced this issue Jul 21, 2023
…7631)

* Fixes Phys_location RFC3339 issue #7630

* Integration Test Case updates for  #7630

* Documentation updates for  #7630

* CHANGELOG.md updates for  #7630

* PR Review comment Updates for  #7630

* PR Review comment Updates for  #7630

* PR Review comment Updates for  #7630

* PR Review comment Updates for  #7630

* PR Review comment Updates for  #7630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant