Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5775 Kotlin build failed for broken toolchain in docker #3043

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

THRIFT-5775 Kotlin build failed for broken toolchain in docker #3043

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f505b0a
THRIFT-5775 Kotlin build failed for broken toolchain in docker
thomasbruggink Sep 26, 2024
218fc71
Remove gradle toolchains from kotlin and set source/target to java 8
thomasbruggink Sep 28, 2024
b21f431
Manually set the release target for kotlin, remove overwrites from cr…
thomasbruggink Sep 28, 2024
c4720e5
Set toolchain to 17 on the kotlin lib module
thomasbruggink Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ If you do not want to use the same scripts Travis CI does, you can do it manuall

Build the image:

Linux/Mac:
Linux:

thrift$ docker build --build-arg uid=$(id -u) --build-arg gid=$(id -g) -t thrift build/docker/ubuntu-jammy

Windows:
Windows/Mac:

thrift$ docker build -t thrift build/docker/ubuntu-jammy

Expand Down
1 change: 1 addition & 0 deletions build/docker/ubuntu-focal/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ RUN apt-get install -y --no-install-recommends \
ant \
ant-optional \
maven \
openjdk-8-jdk-headless \
openjdk-17-jdk-headless && \
`# Gradle` \
wget https://services.gradle.org/distributions/gradle-$GRADLE_VERSION-bin.zip -q -O /tmp/gradle-$GRADLE_VERSION-bin.zip && \
Expand Down
1 change: 1 addition & 0 deletions build/docker/ubuntu-jammy/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ RUN apt-get install -y --no-install-recommends \
ant \
ant-optional \
maven \
openjdk-8-jdk-headless \
openjdk-17-jdk-headless && \
`# Gradle` \
wget https://services.gradle.org/distributions/gradle-$GRADLE_VERSION-bin.zip -q -O /tmp/gradle-$GRADLE_VERSION-bin.zip && \
Expand Down
Loading