Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5775 Kotlin build failed for broken toolchain in docker #3043

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

THRIFT-5775 Kotlin build failed for broken toolchain in docker #3043

wants to merge 4 commits into from

Commits on Sep 26, 2024

  1. THRIFT-5775 Kotlin build failed for broken toolchain in docker 

    This PR adds JDK 8 to both docker containers to support the kotlin
build.
Kotlin requires toolchain 8 and cant build this without the JDK for that
language level being present.

Also correct readme since docker desktop on Mac also fixes the
permissions with volume sharing automatically.
    @thomasbruggink
    thomasbruggink committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f505b0a View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Remove gradle toolchains from kotlin and set source/target to java 8

    @thomasbruggink
    thomasbruggink committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    218fc71 View commit details
    Browse the repository at this point in the history

  2. Manually set the release target for kotlin, remove overwrites from cr… 

    …oss-test-client/server
    @thomasbruggink
    thomasbruggink committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b21f431 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Set toolchain to 17 on the kotlin lib module

    @thomasbruggink
    thomasbruggink committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    c4720e5 View commit details
    Browse the repository at this point in the history