Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): use submodule on helm release action #30924

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix(helm): use submodule on helm release action #30924

merged 1 commit into from
Nov 14, 2024

Conversation

villebro
Copy link
Member

@villebro villebro commented Nov 14, 2024 •
edited
Loading

SUMMARY

#28498 introduced a regression that broke the Helm chart release workflow, which can be seen on the workflow summary here: https://github.com/apache/superset/actions/workflows/superset-helm-release.yml. This is due to a limitation on using external actions, which can be worked around using submodules. See #12709 which introduced the chart-releaser-action submodule among others.

This PR:

  • Reverts the change in chore: Don't mark Helm releases as latest #28498 so we continue using the submodule.
  • Bumps the SHA on the chart-releaser-action to v1.6.0 which is the latest version and supports the mark_as_latest property.
  • Bumps the Helm chart version to 0.13.1 to retrigger the helm deploy workflow on merge. I considered adding the helm workflow file to the path to retrigger this every time there's a change to the workflow config. However, in the end I decided not to, as it may be confusing if the workflow is triggered when there are no changes to the chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Nov 14, 2024
@dosubot dosubot bot added the deploy:helm label Nov 14, 2024
@villebro villebro changed the title Villebro/helm releaser 1.6.0 fix(helm): use submodule on helm release action Nov 14, 2024
@villebro villebro mentioned this pull request Nov 14, 2024
Merged
9 tasks
@villebro villebro mentioned this pull request Nov 14, 2024
Merged
9 tasks
@villebro villebro merged commit a3e89cb into apache:master Nov 14, 2024
57 of 61 checks passed
@villebro villebro deleted the villebro/helm-releaser-1.6.0 branch November 14, 2024 21:47
@villebro villebro mentioned this pull request Nov 14, 2024
Merged
asher-lab added a commit to asher-lab/superset that referenced this pull request Nov 22, 2024
@asher-lab @michael-s-molina
@sadpandajoe @mistercrunch @msyavuz @geido @villebro @PaoloTerzi @samarsrivastav @rusackas @amotl @LevisNgigi @dependabot @eschutho @theoriginalgri @lodu @betodealmeida @github-actions @actions-user @justinpark @dimbleby @jpchev @lindenh @seiyab
fix(import): Merge apache/master and resolve conflicts (#20)
8b446df 
* fix: Exception handling for SQL Lab views (apache#30897)

* fix: don't show metadata for embedded dashboards (apache#30875)

* feat: add logging durations for screenshot async service (apache#30884)

* refactor(Avatar): Migrate Avatar to Ant Design 5 (apache#30740)

* refactor(input): Migrate Input component to Ant Design 5 (apache#30730)

* fix(empty dashboards): Allow downloading a screenshot of an empty dashboard (apache#30767)

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* chore(ci): add tai and michael to helm owners (apache#30925)

* fix(helm): use submodule on helm release action (apache#30924)

* docs: add Free2Move to INTHEWILD.md (apache#30930)

* fix: blocks UI elements on right side (apache#30886)

Co-authored-by: Evan Rusackas <evan@preset.io>

* chore(deps): Migrate from `crate[sqlalchemy]` to `sqlalchemy-cratedb` (apache#29243)

* chore: update change log, UPDATING.md and bug-report.yml for 4.1 release (apache#30915)

* chore(docs): Update list of supported databases to include CrateDB (apache#30946)

* feat(trino,presto): add missing time grains (apache#30926)

* fix(Dashboard): Exclude edit param in async screenshot (apache#30962)

* fix(Card): Use correct class names for Ant Design 5 Card component (apache#30964)

* chore(Accessibility): Fix accessibility for 'Show x entries' dropdown in tables (apache#30818)

* build(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /superset-frontend/cypress-base (apache#30969)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(release validation): scripts now support RSA and EDDSA keys. (apache#30967)

* build(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (apache#30970)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: add performance information to tooltip (apache#30948)

* fix(helm-chart): Fix broken PodDisruptionBudget due to introduction of extraLabels. (apache#30966)

* chore(helm): bumping app version to 4.1.1 in helm chart (apache#30918)

* chore: add unit tests for `is_mutating()` (apache#31021)

* chore(🦾): bump python numexpr 2.10.0 -> 2.10.1 (apache#31006)

Co-authored-by: GitHub Action <action@github.com>

* chore(🦾): bump python cffi 1.16.0 -> 1.17.1 (apache#31002)

Co-authored-by: GitHub Action <action@github.com>

* chore(🦾): bump python flask-babel subpackage(s) (apache#31000)

Co-authored-by: GitHub Action <action@github.com>

* fix(Dashboard): Retain colors when color scheme not set (apache#30646)

* fix(explore): verified props is not updated (apache#31008)

* chore: publish wheels (apache#30981)

* docs: Embedded sdk (apache#30972)

* fix(imports): import query_context for imports with charts (apache#30887)

* docs: Update doc about CSV upload (apache#30867)

Co-authored-by: Evan Rusackas <evan@preset.io>

* chore(🦾): bump python cattrs 23.2.3 -> 24.1.2 (apache#30998)

Co-authored-by: GitHub Action <action@github.com>

* fix(dataset): use sqlglot for DML check (apache#31024)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Joe Li <joe@preset.io>
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Paolo Terzi <PaoloTerzi@users.noreply.github.com>
Co-authored-by: Sukuna <90980311+samarsrivastav@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Andreas Motl <andreas.motl@elmyra.de>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Levis Mbote <111055098+LevisNgigi@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Christoph Keller <github@christophkeller.cc>
Co-authored-by: lodu <48859312+lodu@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Co-authored-by: David Hotham <david.hotham@microsoft.com>
Co-authored-by: Giampaolo Capelli <giampaolo.capelli@gmail.com>
Co-authored-by: Linden <zairrow@gmail.com>
Co-authored-by: Seiya <20365512+seiyab@users.noreply.github.com>
Co-authored-by: Asher Manangan <amanangan@powercosts.com>
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@villebro @nyohasstium
fix(helm): use submodule on helm release action (apache#30924)
942a3f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@nytai nytai nytai approved these changes

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
deploy:helm github_actions Pull requests that update GitHub Actions code size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villebro @nytai @michael-s-molina